Skip to content

CLN: Linting tailing whitespaces, and fixing remaining cases #24286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018
Merged

CLN: Linting tailing whitespaces, and fixing remaining cases #24286

merged 1 commit into from
Dec 14, 2018

Conversation

datapythonista
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback I guess this makes sense. Not sure if there is any reason to exclude html or csv files, let me know if that's the case.

@datapythonista datapythonista added CI Continuous Integration Clean labels Dec 14, 2018
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #24286 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24286      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         162      162              
  Lines       51828    51828              
==========================================
- Hits        47799    47798       -1     
- Misses       4029     4030       +1
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/json.py 92.61% <0%> (-0.48%) ⬇️
pandas/util/testing.py 87.51% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4efc819...712715b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #24286 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24286      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         162      162              
  Lines       51828    51828              
==========================================
- Hits        47799    47798       -1     
- Misses       4029     4030       +1
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/json.py 92.61% <0%> (-0.48%) ⬇️
pandas/util/testing.py 87.51% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4efc819...712715b. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 14, 2018
@jreback jreback merged commit 7b0fa8e into pandas-dev:master Dec 14, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@ghost
Copy link

ghost commented Jun 13, 2019

@datapythonista, it's "trailing whitespace" not "tailing whitespace". easy mistake to make :)
noticed it while looking at CI log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants