REF: Period check compatabile with #24285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @TomAugspurger! Thanks for submitting the PR.
|
|
lgtm. merge on green. |
|
Travis fail is hypothesis |
|
Yep, ignoring it though I'll keep my eye on the merge build. |
|
There are 5 places in indexes.period where DIFFERENT_FREQ/IncompatibleFrequency are used. Should these dispatch to self._data._check_compatible_with? |
|
Seems reasonable to me.
…On Fri, Dec 14, 2018 at 4:12 PM jbrockmendel ***@***.***> wrote:
There are 5 places in indexes.period where
DIFFERENT_FREQ/IncompatibleFrequency are used. Should these dispatch to
self._data._check_compatible_with?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#24285 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIlPRqRIGP72oPIB-RZP5m4-rH2Uhks5u5CJPgaJpZM4ZUO82>
.
|
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #24024
cc @jbrockmendel
There are a couple cases in
PeriodArray.__setitem__that I didn't update, becausePeriodArray.__setitem__is being remove entirely in #24024.