-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix flake8 issues in whatsnew v10* and v11* #24277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24277 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 162 162
Lines 51789 51789
=======================================
Hits 47762 47762
Misses 4027 4027
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24277 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 162 162
Lines 51828 51828
=======================================
Hits 47798 47798
Misses 4030 4030
Continue to review full report at Codecov.
|
doc/source/whatsnew/v0.10.0.rst
Outdated
@@ -3,13 +3,6 @@ | |||
v0.10.0 (December 17, 2012) | |||
--------------------------- | |||
|
|||
{{ header }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need the {{ header }}
? cc @datapythonista
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should be in all pages. It is where we do the import pandas as pd
and set some options. But even in pages where there is no code, I need it there because with the new sphinx theme, I'll be controlling the navigation with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it back. It was a mistake. I deleted with the include block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just few comments
doc/source/whatsnew/v0.10.1.rst
Outdated
@@ -3,13 +3,6 @@ | |||
v0.10.1 (January 22, 2013) | |||
--------------------------- | |||
|
|||
{{ header }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restore the header here too
@@ -47,6 +40,7 @@ You may need to upgrade your existing data files. Please visit the | |||
.. ipython:: python | |||
:suppress: | |||
:okexcept: | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a blank line before the import here
doc/source/whatsnew/v0.11.0.rst
Outdated
@@ -3,13 +3,6 @@ | |||
v0.11.0 (April 22, 2013) | |||
------------------------ | |||
|
|||
{{ header }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
I did not understand the reason for the failure. Can you point me to any document on how to debug? |
Seems unrelated to your changes, didn't check in detail, but I guess it's a test that fails randomly sometimes. Can you merge master and push again, so the CI reruns. |
thanks @saurav2608 |
closes #24258
closes #24259
git diff upstream/master -u -- "*.py" | flake8 --diff