Skip to content

DOC: Fix flake8 issues in whatsnew v10* and v11* #24277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2018

Conversation

saurav2608
Copy link

@saurav2608 saurav2608 commented Dec 14, 2018

closes #24258
closes #24259

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #24277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24277   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         162      162           
  Lines       51789    51789           
=======================================
  Hits        47762    47762           
  Misses       4027     4027
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43ac97...3cd4a27. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #24277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24277   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         162      162           
  Lines       51828    51828           
=======================================
  Hits        47798    47798           
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040f06f...1ed46ec. Read the comment docs.

@@ -3,13 +3,6 @@
v0.10.0 (December 17, 2012)
---------------------------

{{ header }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need the {{ header }} ? cc @datapythonista

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be in all pages. It is where we do the import pandas as pd and set some options. But even in pages where there is no code, I need it there because with the new sphinx theme, I'll be controlling the navigation with this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back. It was a mistake. I deleted with the include block.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just few comments

@@ -3,13 +3,6 @@
v0.10.1 (January 22, 2013)
---------------------------

{{ header }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore the header here too

@@ -47,6 +40,7 @@ You may need to upgrade your existing data files. Please visit the
.. ipython:: python
:suppress:
:okexcept:
import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a blank line before the import here

@@ -3,13 +3,6 @@
v0.11.0 (April 22, 2013)
------------------------

{{ header }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@saurav2608
Copy link
Author

I did not understand the reason for the failure. Can you point me to any document on how to debug?

@datapythonista
Copy link
Member

Seems unrelated to your changes, didn't check in detail, but I guess it's a test that fails randomly sometimes. Can you merge master and push again, so the CI reruns.

@jreback jreback added this to the 0.24.0 milestone Dec 14, 2018
@jreback jreback merged commit 4974758 into pandas-dev:master Dec 14, 2018
@jreback
Copy link
Contributor

jreback commented Dec 14, 2018

thanks @saurav2608

@saurav2608 saurav2608 deleted the whatsnew-10 branch December 16, 2018 07:04
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants