implement independent parts of #24024

[jbrockmendel]

@TomAugspurger just for kicks I went through to see how much of #24024 could be implemented without actually changing anything. Could've squeezed out a little bit more; as-is only about 6% by line-count. If it's not worth the rebasing hassle, I'll close.

[pep8speaks]

Hello @jbrockmendel! Thanks for submitting the PR.

• There are no PEP8 issues in the file pandas/core/arrays/datetimelike.py !

• There are no PEP8 issues in the file pandas/core/arrays/datetimes.py !

• There are no PEP8 issues in the file pandas/core/arrays/period.py !

• There are no PEP8 issues in the file pandas/core/arrays/timedeltas.py !

• There are no PEP8 issues in the file pandas/core/indexes/datetimes.py !

• There are no PEP8 issues in the file pandas/io/formats/format.py !

• There are no PEP8 issues in the file pandas/tests/indexes/datetimes/test_astype.py !

• There are no PEP8 issues in the file pandas/tests/indexes/period/test_astype.py !

• There are no PEP8 issues in the file pandas/tests/indexes/timedeltas/test_astype.py !

• There are no PEP8 issues in the file pandas/tests/io/json/test_pandas.py !

• There are no PEP8 issues in the file pandas/tests/series/test_datetime_values.py !

• There are no PEP8 issues in the file pandas/tests/series/test_timeseries.py !

• There are no PEP8 issues in the file pandas/tests/test_base.py !

• There are no PEP8 issues in the file pandas/util/testing.py !

[TomAugspurger]

Looks good. I restarted the CI services. Do you know if the monotonic changes on the array classes are actually hit by tests on this PR? Not a big deal, either way.

…

On Thu, Dec 13, 2018 at 10:15 PM PEP8 Speaks ***@***.***> wrote: Hello @jbrockmendel <https://github.com/jbrockmendel>! Thanks for submitting the PR. - There are no PEP8 issues in the file pandas/core/arrays/datetimelike.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/core/arrays/datetimelike.py> ! - There are no PEP8 issues in the file pandas/core/arrays/datetimes.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/core/arrays/datetimes.py> ! - There are no PEP8 issues in the file pandas/core/arrays/period.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/core/arrays/period.py> ! - There are no PEP8 issues in the file pandas/core/arrays/timedeltas.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/core/arrays/timedeltas.py> ! - There are no PEP8 issues in the file pandas/core/indexes/datetimes.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/core/indexes/datetimes.py> ! - There are no PEP8 issues in the file pandas/io/formats/format.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/io/formats/format.py> ! - There are no PEP8 issues in the file pandas/tests/indexes/datetimes/test_astype.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/tests/indexes/datetimes/test_astype.py> ! - There are no PEP8 issues in the file pandas/tests/indexes/period/test_astype.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/tests/indexes/period/test_astype.py> ! - There are no PEP8 issues in the file pandas/tests/indexes/timedeltas/test_astype.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/tests/indexes/timedeltas/test_astype.py> ! - There are no PEP8 issues in the file pandas/tests/io/json/test_pandas.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/tests/io/json/test_pandas.py> ! - There are no PEP8 issues in the file pandas/tests/series/test_datetime_values.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/tests/series/test_datetime_values.py> ! - There are no PEP8 issues in the file pandas/tests/series/test_timeseries.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/tests/series/test_timeseries.py> ! - There are no PEP8 issues in the file pandas/tests/test_base.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/tests/test_base.py> ! - There are no PEP8 issues in the file pandas/util/testing.py <https://github.com/jbrockmendel/pandas/blob/bb71995dbbe3d538cf94bcee0fc023f56a5def0c/pandas/util/testing.py> ! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24276 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIilV9_jagzsJdvV295wOraGCjdsGks5u4yXTgaJpZM4ZS26J> .

[codecov]

Codecov Report

Merging #24276 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24276      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         162      162              
  Lines       51789    51797       +8     
==========================================
+ Hits        47762    47771       +9     
+ Misses       4027     4026       -1

Flag	Coverage Δ
#multiple	90.63% <100%> (ø)	⬆️
#single	43.01% <58.53%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/arrays/datetimelike.py	96.38% <100%> (+0.03%)	⬆️
pandas/io/formats/format.py	97.98% <100%> (ø)	⬆️
pandas/core/arrays/timedeltas.py	87.16% <100%> (+0.05%)	⬆️
pandas/core/indexes/datetimes.py	96.33% <100%> (-0.02%)	⬇️
pandas/core/arrays/datetimes.py	98.57% <100%> (+0.01%)	⬆️
pandas/core/arrays/period.py	98.5% <100%> (+0.21%)	⬆️
pandas/util/testing.py	87.51% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43ac97...bb71995. Read the comment docs.

[codecov]

Codecov Report

Merging #24276 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24276      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         162      162              
  Lines       51789    51797       +8     
==========================================
+ Hits        47762    47771       +9     
+ Misses       4027     4026       -1

Flag	Coverage Δ
#multiple	90.63% <100%> (ø)	⬆️
#single	43.01% <58.53%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/arrays/datetimelike.py	96.38% <100%> (+0.03%)	⬆️
pandas/io/formats/format.py	97.98% <100%> (ø)	⬆️
pandas/core/arrays/timedeltas.py	87.16% <100%> (+0.05%)	⬆️
pandas/core/indexes/datetimes.py	96.33% <100%> (-0.02%)	⬇️
pandas/core/arrays/datetimes.py	98.57% <100%> (+0.01%)	⬆️
pandas/core/arrays/period.py	98.5% <100%> (+0.21%)	⬆️
pandas/util/testing.py	87.51% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43ac97...bb71995. Read the comment docs.

[jreback]

lgtm. @TomAugspurger merge if ok (as you will have to rebase on top)