EHN: Add filename to FileNotFoundError #24266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @milliams! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 05, 2019 at 19:42 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #24266 +/- ##
==========================================
+ Coverage 92.22% 92.22% +<.01%
==========================================
Files 162 162
Lines 51785 51785
==========================================
+ Hits 47758 47759 +1
+ Misses 4027 4026 -1
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 13, 2018
gfyoung
added
Enhancement
Error Reporting
|
@milliams can you merge master and update to comments |
|
closing as stale, if you want to continue, pls ping. |
|
@jreback : I'm going to push this through. |
|
@jreback : I rebased and addressed my own comment, and all is still green. PTAL. |
jreback
approved these changes
Jan 5, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pandas raises a
FileNotFoundError, it was not setting thefilenamecomponent.This adds in that feature as well a test for it.