Skip to content

BLD: json deprecated unicode capi #24254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2018
Merged

BLD: json deprecated unicode capi #24254

merged 1 commit into from
Dec 13, 2018

Conversation

chris-b1
Copy link
Contributor

closes #24221

just copying the upstream fix
ultrajson/ultrajson@ab8f419

@chris-b1 chris-b1 added the Build Library building on various platforms label Dec 12, 2018
@WillAyd
Copy link
Member

WillAyd commented Dec 12, 2018

Easy enough, but isn't this missing the declaration of new_obj as a point to a PyObject?

@WillAyd WillAyd added the IO JSON read_json, to_json, json_normalize label Dec 12, 2018
@WillAyd
Copy link
Member

WillAyd commented Dec 12, 2018

Nevermind above comment - I see it's intentionally slightly different than upstream fix

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #24254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24254   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         162      162           
  Lines       51768    51768           
=======================================
  Hits        47739    47739           
  Misses       4029     4029
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc42f9...55c4a40. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 12, 2018 •
edited
Loading

Codecov Report

Merging #24254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24254   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         162      162           
  Lines       51768    51768           
=======================================
  Hits        47739    47739           
  Misses       4029     4029
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc42f9...55c4a40. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 13, 2018
@jreback jreback merged commit e498905 into pandas-dev:master Dec 13, 2018
@jreback
Copy link
Contributor

jreback commented Dec 13, 2018

thanks @chris-b1

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@chris-b1 @Pingviinituutti
BLD: json deprecated unicode capi (pandas-dev#24254)
f8cbafc
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@chris-b1 @Pingviinituutti
BLD: json deprecated unicode capi (pandas-dev#24254)
0ece8a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Library building on various platforms IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

Replace deprecated Py_Unicode_EncodeUTF8 in objToJSON.c
3 participants
@chris-b1 @WillAyd @jreback