Skip to content

Fix flake8 issues on v22, v23 and v24rst #24217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2018
Merged

Fix flake8 issues on v22, v23 and v24rst #24217

merged 3 commits into from
Dec 11, 2018

Conversation

thoo
Copy link
Contributor

@thoo thoo commented Dec 11, 2018 •
edited
Loading

datapythonista
datapythonista reviewed Dec 11, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the fixes @thoo

just one wrong indentation I think

doc/source/whatsnew/v0.23.0.rst Outdated
@@ -336,7 +336,8 @@ outside the existing valid values while preserving those inside. (:issue:`16284

.. ipython:: python

ser = pd.Series([np.nan, np.nan, 5, np.nan, np.nan, np.nan, 13, np.nan, np.nan])
ser = pd.Series([np.nan, np.nan, 5, np.nan, np.nan,
np.nan, 13, np.nan, np.nan])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing one more space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

@datapythonista datapythonista self-assigned this Dec 11, 2018
@saurav2608 saurav2608 mentioned this pull request Dec 11, 2018
Closed
datapythonista
datapythonista approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @thoo

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #24217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24217   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         162      162           
  Lines       51763    51763           
=======================================
  Hits        47733    47733           
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91802fb...70802af. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 11, 2018 •
edited
Loading

Codecov Report

Merging #24217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24217   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         162      162           
  Lines       51763    51763           
=======================================
  Hits        47733    47733           
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91802fb...ac5aa75. Read the comment docs.

@thoo thoo mentioned this pull request Dec 11, 2018
Closed
@thoo thoo changed the title Fix flake8 issues on v22 and v23rst Fix flake8 issues on v22, v23 and v24rst Dec 11, 2018
datapythonista
datapythonista approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @thoo

but in general, once you've got a PR approved, better to open a new one, instead of modifying it

@thoo
Copy link
Contributor Author

thoo commented Dec 11, 2018

@datapythonista Thanks. I will definitely do it next time.

@WillAyd WillAyd merged commit 7f75389 into pandas-dev:master Dec 11, 2018
This was referenced Dec 11, 2018
Closed
Closed
@thoo thoo deleted the flake8_whatsnew22 branch January 2, 2019 20:26
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@thoo @Pingviinituutti
Fix flake8 issues on v22, v23 and v24rst (pandas-dev#24217)
eef17c2
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@thoo @Pingviinituutti
Fix flake8 issues on v22, v23 and v24rst (pandas-dev#24217)
3c8dac0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees

@datapythonista datapythonista

Labels
Clean Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC: Fix flake8 issues in doc/source/whatsnew/v0.24.0.rst
3 participants
@thoo @datapythonista @WillAyd