Skip to content

CLN: Remove tmp.xlsx #24194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2018
Merged

CLN: Remove tmp.xlsx #24194

merged 1 commit into from
Dec 10, 2018

Conversation

mroeschke
Copy link
Member

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #24194 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24194      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files         162      162              
  Lines       51723    51723              
==========================================
- Hits        47695    47694       -1     
- Misses       4028     4029       +1
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 43.03% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/json.py 92.61% <0%> (-0.48%) ⬇️
pandas/util/testing.py 87.51% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77278ba...aaa8664. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #24194 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24194      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files         162      162              
  Lines       51723    51723              
==========================================
- Hits        47695    47694       -1     
- Misses       4028     4029       +1
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 43.03% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/json.py 92.61% <0%> (-0.48%) ⬇️
pandas/util/testing.py 87.51% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77278ba...aaa8664. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 10, 2018
@jreback jreback merged commit 029cde2 into pandas-dev:master Dec 10, 2018
@jreback
Copy link
Contributor

jreback commented Dec 10, 2018

thanks

@datapythonista
Copy link
Member

Thanks @mroeschke, I didn't see it in the merge PR, but I saw it in a different PR yesterday too. Will take a look and see where it's generated, in theory we fixed recently the issue on files that were left after running the docstrings.

Not sure if it'd be possible to have a check in the CI too.

@mroeschke mroeschke deleted the rm_tmp_excel_file branch December 10, 2018 16:10
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants