DOC: Fix docstring of window.Expanding/Rolling.apply and document *args and **kwargs #24184

LJArendse · 2018-12-09T19:47:34Z

This pull request will

Fix docstring formatting for pandas.core.window.Expanding.apply and pandas.core.window.Rolling.apply
Document *args and **kwargs parameters:
The following functions had *args and **kwargs added to their docstring:
Rolling.max
Expanding.max
EWM.mean
EWM.std
EWM.var
The following functions had **kwargs added to their docstring:
Rolling.skew
Expanding.skew
Rolling.cov
Expanding.cov
EWM.cov
EWM.corr

…and pandas.core.window.Rolling.apply The following 'errors' were fixed: - Summary does not start with a capital letter - Unknown parameters {\*args and \*\*kwargs are passed to the function} - Parameter "func" description should finish with "." - Parameter "raw" description should start with a capital letter - Parameter "\*args and \*\*kwargs are passed to the function" has no type - Parameter "\*args and \*\*kwargs are passed to the function" description should finish with "." - No Returns section found The following 'warning' was addressed: - See Also section not found

pep8speaks · 2018-12-09T19:47:36Z

Hello @LJArendse! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on January 07, 2019 at 11:30 Hours UTC

pandas/core/window.py

datapythonista

Besides the comment, you have PEP8 issues in your code (tabs), it's probably worth using a validator in your editor.

Also, if instead of describing what you did, you can just copy the output of the validation script, that's more useful to review.

pandas/core/window.py

codecov · 2018-12-09T20:15:02Z

Codecov Report

Merging #24184 into master will decrease coverage by 49.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #24184       +/-   ##
===========================================
- Coverage   92.21%   43.03%   -49.18%     
===========================================
  Files         162      162               
  Lines       51723    51723               
===========================================
- Hits        47695    22261    -25434     
- Misses       4028    29462    +25434

Flag	Coverage Δ
#multiple	`?`
#single	`43.03% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/window.py	`28.93% <ø> (-67.47%)`	⬇️
pandas/io/formats/latex.py	`0% <0%> (-100%)`	⬇️
pandas/core/categorical.py	`0% <0%> (-100%)`	⬇️
pandas/io/sas/sas_constants.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/plotting.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/converter.py	`0% <0%> (-100%)`	⬇️
pandas/io/formats/html.py	`0% <0%> (-98.62%)`	⬇️
pandas/core/groupby/categorical.py	`0% <0%> (-95.46%)`	⬇️
pandas/io/sas/sas7bdat.py	`0% <0%> (-91.17%)`	⬇️
pandas/io/sas/sas_xport.py	`0% <0%> (-90.15%)`	⬇️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbb137...764f8a8. Read the comment docs.

codecov · 2018-12-09T20:15:03Z

Codecov Report

Merging #24184 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24184      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.02%     
==========================================
  Files         166      166              
  Lines       52478    52382      -96     
==========================================
- Hits        48483    48389      -94     
+ Misses       3995     3993       -2

Flag	Coverage Δ
#multiple	`90.8% <100%> (-0.02%)`	⬇️
#single	`43.01% <100%> (-0.03%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/window.py	`96.4% <100%> (-0.01%)`	⬇️
pandas/core/internals/construction.py	`95.93% <0%> (-0.73%)`	⬇️
pandas/core/nanops.py	`94.36% <0%> (-0.55%)`	⬇️
pandas/core/internals/concat.py	`96.45% <0%> (-0.37%)`	⬇️
pandas/core/arrays/datetimes.py	`97.68% <0%> (-0.34%)`	⬇️
pandas/core/indexes/datetimelike.py	`98.52% <0%> (-0.32%)`	⬇️
pandas/core/internals/blocks.py	`94.3% <0%> (-0.2%)`	⬇️
pandas/core/indexes/period.py	`92.06% <0%> (-0.06%)`	⬇️
pandas/core/arrays/categorical.py	`95.43% <0%> (-0.05%)`	⬇️
pandas/core/indexes/category.py	`98.61% <0%> (-0.04%)`	⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62506ca...8bedb9d. Read the comment docs.

pandas/core/window.py

datapythonista · 2018-12-09T20:22:55Z

And if you can please provide the output of the validation script in the description, as mentioned before, that would be helpful.

datapythonista

lgtm

For next time, it's useful if you also copy the rendered docstring in the description, not only the list of errors. As the docstring is splitted in different variables, and some values are not explicit (like %(name)s, it's some times easier to understand the rendered docstring.

LJArendse · 2018-12-10T07:43:03Z

@datapythonista
will take a look at why the pandas-dev.pandas check is failing at line 2275. Could be the changes to _doc_template used in the decorator @appender(_doc_template) ...?

2018-12-09T21:02:08.3673583Z ##[error]pandas/core/window.py(2275,): error SS04: pandas.core.window.EWM.mean: Summary contains heading whitespaces
2018-12-09T21:02:09.3424503Z Validate docstrings (GL06, SS04, PR03, PR05, EX04) DONE
2018-12-09T21:02:09.3426271Z ##[error]Bash exited with code '1'.

datapythonista · 2018-12-10T15:07:48Z

can you run ./scripts/validate_docstrings.py pandas.core.window.EWM.mean and see how the docstring looks like? that should give you an idea of the problem.

I think the problem it's indeed removing the indentation _doc_template.

@appender

…y'] docstring, and Remove @appender(_doc_template) decorator for rolling apply and expanding apply

LJArendse · 2018-12-10T16:45:44Z

Fixed Summary contains heading whitespace for pandas.core.window.EWM.mean
Maintained fixes to pandas.core.window.Expanding.apply and pandas.core.window.Rolling.apply
(see below)

pandas.core.window.EWM.mean

python scripts/validate_docstrings.py pandas.core.window.EWM.mean

################################################################################
################### Docstring (pandas.core.window.EWM.mean)  ###################
################################################################################

Exponential weighted moving average.

Returns
-------
same type as input

See Also
--------
Series.ewm
DataFrame.ewm

################################################################################
################################## Validation ##################################
################################################################################

3 Errors found:
        Parameters {*args, **kwargs} not documented
        Missing description for See Also "Series.ewm" reference
        Missing description for See Also "DataFrame.ewm" reference
2 Warnings found:
        No extended summary found
        No examples section found

pandas.core.window.Expanding.apply

################################################################################
################ Docstring (pandas.core.window.Expanding.apply) ################
################################################################################

The expanding function apply.

Parameters
----------
func : function
    Must produce a single value from an ndarray input if ``raw=True``
    or a Series if ``raw=False``.
raw : bool, default None
    * ``False`` : passes each row or column as a Series to the
      function.
    * ``True`` or ``None`` : the passed function will receive ndarray
      objects instead.
      If you are just applying a NumPy reduction function this will
      achieve much better performance.

    The `raw` parameter is required and will show a FutureWarning if
    not passed. In the future `raw` will default to False.

    .. versionadded:: 0.23.0
*args, **kwargs :
    Arguments and keyword arguments to be passed into func.

Returns
-------
Same type as input

See Also
--------
Series.expanding : Series expanding.
DataFrame.expanding : DataFrame expanding.

################################################################################
################################## Validation ##################################
################################################################################

3 Errors found:
        Parameters {kwargs, args} not documented
        Unknown parameters {*args, **kwargs :}
        Parameter "raw" description should start with a capital letter
2 Warnings found:
        No extended summary found
        No examples section found

pandas.core.window.Rolling.apply

################################################################################
################# Docstring (pandas.core.window.Rolling.apply) #################
################################################################################

The rolling function apply.

Parameters
----------
func : function
    Must produce a single value from an ndarray input if ``raw=True``
    or a Series if ``raw=False``.
raw : bool, default None
    * ``False`` : passes each row or column as a Series to the
      function.
    * ``True`` or ``None`` : the passed function will receive ndarray
      objects instead.
      If you are just applying a NumPy reduction function this will
      achieve much better performance.

    The `raw` parameter is required and will show a FutureWarning if
    not passed. In the future `raw` will default to False.

    .. versionadded:: 0.23.0
*args, **kwargs :
    Arguments and keyword arguments to be passed into func.

Returns
-------
Same type as input

See Also
--------
Series.rolling : Series rolling.
DataFrame.rolling : DataFrame rolling.

################################################################################
################################## Validation ##################################
################################################################################

3 Errors found:
        Parameters {args, kwargs} not documented
        Unknown parameters {*args, **kwargs :}
        Parameter "raw" description should start with a capital letter
2 Warnings found:
        No extended summary found
        No examples section found

LJArendse · 2018-12-10T17:39:26Z

@datapythonista looks like the fixes have passed the checks :)

datapythonista

thanks @LJArendse

pandas/core/window.py

WillAyd · 2018-12-11T21:10:46Z

Yea I think that should work more universally. If you can try and check tenderer output would be preferable if it works

…

Sent from my iPhone

On Dec 11, 2018, at 12:34 PM, LJ ***@***.***> wrote: @LJArendse commented on this pull request. In pandas/core/window.py: > - \*args and \*\*kwargs are passed to the function""") + Returns Hey @WillAyd, I did it in the _shared_docs['apply'] because the @appender(_doc_template) decorator on the window.Expanding/Rolling.apply methods is what threw the original validation error No Returns section found. I was also not sure whether my changes, for window.Expanding/Rolling.apply, are relevant for the other functions wrapped with @appender(_doc_template). I see your point though, I am happy to update the _doc_template From: _doc_template = """ Returns ------- same type as input See Also -------- Series.%(name)s DataFrame.%(name)s """ To: _doc_template = """ Returns ------- Series or DataFrame Return type is determined by the caller. See Also -------- Series.%(name)s : Series %(name)s. DataFrame.%(name)s : DataFrame %(name)s. """ . . . if you agree with my modification to _doc_template ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

LJArendse · 2018-12-12T19:37:06Z

@WillAyd I agree, updated the _doc_template as discussed.

pandas/core/window.py

datapythonista · 2018-12-30T23:54:46Z

what is the status of this? anything pending? @LJArendse @WillAyd

LJArendse · 2018-12-31T03:16:40Z

Hi @datapythonista
The work for fixing the docstring of window.Expanding/Rolling.apply is done.

Additional to this, from what I understand, I will be investigating the best way to add *args, **kwargs to _doc_template. For the moment it is looking like I will add *args, **kwargs to _doc_template and then modify the docstrings of skew, cov, and corr. If you still want me to do this investigation, should the title of the pull request be modified to reflect these additional changes being made?

I will only be able to work on this after the 2nd of Jan.

…indow-rolling-apply-and-expanding-apply

LJArendse · 2019-01-06T19:37:55Z

In the progress of adding the *args and **kwargs parameters to the following:

rolling.max - *args and **kwargs
expanding.max - *args and **kwargs

rolling.cov - **kwargs
expanding.cov - **kwargs
EWM.cov - **kwargs

EWM.mean - *args and **kwargs
EWM.std - *args and **kwargs
EWM.var - *args and **kwargs
EWM.corr - **kwargs

…nd EWM.cov

datapythonista · 2019-01-07T10:18:28Z

lgtm, let us know when you're done.

And feel free to leave some of the docstring fixes to other PRs, in general it's better to have smaller PRs, than a large one.

@WillAyd if you can take a look.

LJArendse · 2019-01-07T11:00:11Z

Done. I am busy uploading the before and after validation output for each updated docstring.

pandas/core/window.py

LJArendse · 2019-01-07T11:38:23Z

Expanding.apply

Before:
python scripts/validate_docstrings.py pandas.core.window.Expanding.apply

################################################################################
################ Docstring (pandas.core.window.Expanding.apply) ################
################################################################################

expanding function apply.

Parameters
----------
func : function
    Must produce a single value from an ndarray input if ``raw=True``
    or a Series if ``raw=False``
raw : bool, default None
    * ``False`` : passes each row or column as a Series to the
      function.
    * ``True`` or ``None`` : the passed function will receive ndarray
      objects instead.
      If you are just applying a NumPy reduction function this will
      achieve much better performance.

    The `raw` parameter is required and will show a FutureWarning if
    not passed. In the future `raw` will default to False.

    .. versionadded:: 0.23.0

\*args and \*\*kwargs are passed to the function
        Returns
        -------
        same type as input

        See Also
        --------
        Series.expanding
        DataFrame.expanding

################################################################################
################################## Validation ##################################
################################################################################

8 Errors found:
        Summary does not start with a capital letter
        Parameters {kwargs, args} not documented
        Unknown parameters {\*args and \*\*kwargs are passed to the function}
        Parameter "func" description should finish with "."
        Parameter "raw" description should start with a capital letter
        Parameter "\*args and \*\*kwargs are passed to the function" has no type
        Parameter "\*args and \*\*kwargs are passed to the function" description should finish with "."
        No Returns section found
3 Warnings found:
        No extended summary found
        See Also section not found
        No examples section found

After:

################################################################################
################ Docstring (pandas.core.window.Expanding.apply) ################
################################################################################

The expanding function's apply function.

Parameters
----------
func : function
    Must produce a single value from an ndarray input if ``raw=True``
    or a Series if ``raw=False``.
raw : bool, default None
    * ``False`` : passes each row or column as a Series to the
      function.
    * ``True`` or ``None`` : the passed function will receive ndarray
      objects instead.
      If you are just applying a NumPy reduction function this will
      achieve much better performance.

    The `raw` parameter is required and will show a FutureWarning if
    not passed. In the future `raw` will default to False.

    .. versionadded:: 0.23.0
*args, **kwargs
    Arguments and keyword arguments to be passed into func.

Returns
-------
Series or DataFrame
    Return type is determined by the caller.

See Also
--------
Series.expanding : Series expanding.
DataFrame.expanding : DataFrame expanding.

################################################################################
################################## Validation ##################################
################################################################################

3 Errors found:
        Parameters {kwargs, args} not documented
        Unknown parameters {*args, **kwargs}
        Parameter "raw" description should start with a capital letter
2 Warnings found:
        No extended summary found
        No examples section found

Final output:

LJArendse · 2019-01-07T11:39:32Z

Rolling.apply

Before:
python scripts/validate_docstrings.py pandas.core.window.Rolling.apply

################################################################################
################# Docstring (pandas.core.window.Rolling.apply) #################
################################################################################

rolling function apply.

Parameters
----------
func : function
    Must produce a single value from an ndarray input if ``raw=True``
    or a Series if ``raw=False``
raw : bool, default None
    * ``False`` : passes each row or column as a Series to the
      function.
    * ``True`` or ``None`` : the passed function will receive ndarray
      objects instead.
      If you are just applying a NumPy reduction function this will
      achieve much better performance.

    The `raw` parameter is required and will show a FutureWarning if
    not passed. In the future `raw` will default to False.

    .. versionadded:: 0.23.0

\*args and \*\*kwargs are passed to the function
        Returns
        -------
        same type as input

        See Also
        --------
        Series.rolling
        DataFrame.rolling

################################################################################
################################## Validation ##################################
################################################################################

8 Errors found:
        Summary does not start with a capital letter
        Parameters {args, kwargs} not documented
        Unknown parameters {\*args and \*\*kwargs are passed to the function}
        Parameter "func" description should finish with "."
        Parameter "raw" description should start with a capital letter
        Parameter "\*args and \*\*kwargs are passed to the function" has no type
        Parameter "\*args and \*\*kwargs are passed to the function" description should finish with "."
        No Returns section found
3 Warnings found:
        No extended summary found
        See Also section not found
        No examples section found

After:

################################################################################
################# Docstring (pandas.core.window.Rolling.apply) #################
################################################################################

The rolling function's apply function.

Parameters
----------
func : function
    Must produce a single value from an ndarray input if ``raw=True``
    or a Series if ``raw=False``.
raw : bool, default None
    * ``False`` : passes each row or column as a Series to the
      function.
    * ``True`` or ``None`` : the passed function will receive ndarray
      objects instead.
      If you are just applying a NumPy reduction function this will
      achieve much better performance.

    The `raw` parameter is required and will show a FutureWarning if
    not passed. In the future `raw` will default to False.

    .. versionadded:: 0.23.0
*args, **kwargs
    Arguments and keyword arguments to be passed into func.

Returns
-------
Series or DataFrame
    Return type is determined by the caller.

See Also
--------
Series.rolling : Series rolling.
DataFrame.rolling : DataFrame rolling.

################################################################################
################################## Validation ##################################
################################################################################

3 Errors found:
        Parameters {args, kwargs} not documented
        Unknown parameters {*args, **kwargs}
        Parameter "raw" description should start with a capital letter
2 Warnings found:
        No extended summary found
        No examples section found

Final output:

datapythonista

lgtm, thanks @LJArendse

@WillAyd merge when you're happy

LJArendse · 2019-01-07T12:30:14Z

The following functions had *args and **kwargs added to their docstring:
Rolling.max
Expanding.max
EWM.mean
EWM.std
EWM.var

I can upload the full before and after validation output if you want (I did not want to upload for each as it will make this thread extra long - unless you are okay with that?).

The final output for each looks as follows:

LJArendse · 2019-01-07T12:37:23Z

The following functions had **kwargs added to their docstring:
Rolling.skew
Expanding.skew
Rolling.cov
Expanding.cov
EWM.cov
EWM.corr

I can upload the full before and after validation output if you want (I did not want to upload for each as it will make the thread extra long - unless you are okay with that?).

The final output for each looks as follows:

WillAyd · 2019-01-07T16:11:17Z

Thanks @LJArendse

…gs and **kwargs (pandas-dev#24184)

LJArendse added 2 commits December 9, 2018 21:50

DOC: Remove trailing trailing whitespace

9c26181

DOC: Fix Line 968:80: E501 line too long (81 > 79 characters)

939dfeb

jreback reviewed Dec 9, 2018

View reviewed changes

pandas/core/window.py Outdated Show resolved Hide resolved

jreback added the Docs label Dec 9, 2018

DOC: Remove * in raw parameter description

4f1e16e

datapythonista reviewed Dec 9, 2018

View reviewed changes

pandas/core/window.py Outdated Show resolved Hide resolved

datapythonista changed the title ~~DOC: Fix docstring formatting for pandas.core.window.Expanding.apply …~~ DOC: Fix docstring of window.Expanding/Rolling.apply Dec 9, 2018

DOC: Restore lines to original form

764f8a8

DOC: Remove tabs

765add7

datapythonista reviewed Dec 9, 2018

View reviewed changes

pandas/core/window.py Outdated Show resolved Hide resolved

DOC: Amend the description of *args, **kwargs

ad0cd6a

datapythonista approved these changes Dec 9, 2018

View reviewed changes

DOC: Return _doc_template to original form, Update _shared_docs['appl…

dead755

…y'] docstring, and Remove @appender(_doc_template) decorator for rolling apply and expanding apply

datapythonista approved these changes Dec 10, 2018

View reviewed changes

datapythonista self-assigned this Dec 11, 2018

WillAyd requested changes Dec 11, 2018

View reviewed changes

pandas/core/window.py Outdated Show resolved Hide resolved

pandas/core/window.py Show resolved Hide resolved

DOC: Modify apply method's return section in docstring

f20e951

WillAyd reviewed Dec 11, 2018

View reviewed changes

pandas/core/window.py Outdated Show resolved Hide resolved

DOC: Simplify explination of the return type in apply docstring

95c3cad

WillAyd requested changes Dec 11, 2018

View reviewed changes

pandas/core/window.py Show resolved Hide resolved

DOC: Modify and improve on the current _doc_template

95cd423

WillAyd requested changes Dec 12, 2018

View reviewed changes

pandas/core/window.py Show resolved Hide resolved

pandas/core/window.py Outdated Show resolved Hide resolved

DOC: Update _shared_docs['apply'] function description

a6447b5

datapythonista reviewed Dec 18, 2018

View reviewed changes

pandas/core/window.py Show resolved Hide resolved

LJArendse added 2 commits January 3, 2019 22:47

Merge branch 'master' into fix-docstring-formatting-for-pandas-core-w…

8e566a0

…indow-rolling-apply-and-expanding-apply

DOC: Add **kwarg parameter to _shared_docs['skew']

b6cad28

LJArendse added 5 commits January 7, 2019 11:29

DOC: Add *args, **kwargs parameters to _shared_docs['max'] docstring

958f16f

Add **kwargs parameter to docstrings of Rolling.cov, Expanding.cov, a…

61d3a92

…nd EWM.cov

DOC: Add *args, **kwargs parameters to EWM.mean docstring

d0a5f03

DOC: Add *args, **kwargs parameters to EWM.std docstring

7c19bae

DOC: Add . to the end of the bias' parameter description

7cc3626

datapythonista reviewed Jan 7, 2019

View reviewed changes

pandas/core/window.py Outdated Show resolved Hide resolved

DOC: Remove : at the of the *args, **kwargs parameters

8bedb9d

datapythonista approved these changes Jan 7, 2019

View reviewed changes

LJArendse changed the title ~~DOC: Fix docstring of window.Expanding/Rolling.apply~~ DOC: Fix docstring of window.Expanding/Rolling.apply and document *args and **kwargs Jan 7, 2019

WillAyd approved these changes Jan 7, 2019

View reviewed changes

WillAyd merged commit 4bf3a0e into pandas-dev:master Jan 7, 2019

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

DOC: Fix docstring of window.Expanding/Rolling.apply and document *ar…

d038ce9

…gs and **kwargs (pandas-dev#24184)

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

DOC: Fix docstring of window.Expanding/Rolling.apply and document *ar…

3f2f01e

…gs and **kwargs (pandas-dev#24184)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOC: Fix docstring of window.Expanding/Rolling.apply and document *args and **kwargs #24184

DOC: Fix docstring of window.Expanding/Rolling.apply and document *args and **kwargs #24184

LJArendse commented Dec 9, 2018 •

edited

Loading

pep8speaks commented Dec 9, 2018 •

edited

Loading

datapythonista left a comment

codecov bot commented Dec 9, 2018

codecov bot commented Dec 9, 2018 •

edited

Loading

datapythonista commented Dec 9, 2018

datapythonista left a comment

LJArendse commented Dec 10, 2018

datapythonista commented Dec 10, 2018

LJArendse commented Dec 10, 2018

LJArendse commented Dec 10, 2018

datapythonista left a comment

WillAyd commented Dec 11, 2018 via email

LJArendse commented Dec 12, 2018

datapythonista commented Dec 30, 2018

LJArendse commented Dec 31, 2018

LJArendse commented Jan 6, 2019

datapythonista commented Jan 7, 2019

LJArendse commented Jan 7, 2019

LJArendse commented Jan 7, 2019 •

edited

Loading

LJArendse commented Jan 7, 2019 •

edited

Loading

datapythonista left a comment

LJArendse commented Jan 7, 2019

LJArendse commented Jan 7, 2019

WillAyd commented Jan 7, 2019

DOC: Fix docstring of window.Expanding/Rolling.apply and document *args and **kwargs #24184

DOC: Fix docstring of window.Expanding/Rolling.apply and document *args and **kwargs #24184

Conversation

LJArendse commented Dec 9, 2018 • edited Loading

pep8speaks commented Dec 9, 2018 • edited Loading

Comment last updated on January 07, 2019 at 11:30 Hours UTC

datapythonista left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 9, 2018

Codecov Report

codecov bot commented Dec 9, 2018 • edited Loading

Codecov Report

datapythonista commented Dec 9, 2018

datapythonista left a comment

Choose a reason for hiding this comment

LJArendse commented Dec 10, 2018

datapythonista commented Dec 10, 2018

LJArendse commented Dec 10, 2018

LJArendse commented Dec 10, 2018

datapythonista left a comment

Choose a reason for hiding this comment

WillAyd commented Dec 11, 2018 via email

LJArendse commented Dec 12, 2018

datapythonista commented Dec 30, 2018

LJArendse commented Dec 31, 2018

LJArendse commented Jan 6, 2019

datapythonista commented Jan 7, 2019

LJArendse commented Jan 7, 2019

LJArendse commented Jan 7, 2019 • edited Loading

Expanding.apply

LJArendse commented Jan 7, 2019 • edited Loading

Rolling.apply

datapythonista left a comment

Choose a reason for hiding this comment

LJArendse commented Jan 7, 2019

LJArendse commented Jan 7, 2019

WillAyd commented Jan 7, 2019

LJArendse commented Dec 9, 2018 •

edited

Loading

pep8speaks commented Dec 9, 2018 •

edited

Loading

codecov bot commented Dec 9, 2018 •

edited

Loading

LJArendse commented Jan 7, 2019 •

edited

Loading

LJArendse commented Jan 7, 2019 •

edited

Loading