-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Link to dev version of contributing guide from README.md #24172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24172 +/- ##
==========================================
+ Coverage 92.21% 92.21% +<.01%
==========================================
Files 162 162
Lines 51723 51723
==========================================
+ Hits 47694 47695 +1
+ Misses 4029 4028 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24172 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 162 162
Lines 51723 51723
=======================================
Hits 47694 47694
Misses 4029 4029
Continue to review full report at Codecov.
|
this would be fine. @jorisvandenbossche @TomAugspurger |
Yeah, that's probably best. That link does occasionally break if a build fails, but not too often. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There are 3 other places in the repo that could be changed too:
My inclination is to change the first, but leave the others alone so that internal references in |
I'm also concerned about duplication between |
I think you can change the first two (and the third could actually use sphinx syntax to make a link, so it always links to the same version) |
@jorisvandenbossche are you ok with this now? |
I think changing the link in overview.rst to be a Sphinx ref makes sense. |
thanks @jamesmyatt |
@jamesmyatt would you be interested in making another PR to update that
last link in contributing.rst?
…On Mon, Dec 17, 2018 at 6:56 AM Jeff Reback ***@***.***> wrote:
thanks @jamesmyatt <https://github.com/jamesmyatt>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24172 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIkVMBsOh8ebyg4U4Tu3C6tKYEQFxks5u55R2gaJpZM4ZKOZH>
.
|
@TomAugspurger , sure. |
README.md should link to the development version of the contributing guide, since the stable version may not match current practice for
master
. For example, see #24069 .I'm not sure this PR is a good idea, but I thought it was easiest open it and get comments directly.