API: Revert breaking .values changes

[TomAugspurger]

User-facing change: Series[period].values nad Series[interval].values
continues to be an ndarray of objects. Recommend .array instead.

There are a handful of related places in pandas where we assumed that
Series[EA].values was an EA.

Part of #23995

[pep8speaks]

Hello @TomAugspurger! Thanks for submitting the PR.

• There are no PEP8 issues in the file pandas/core/base.py !

• There are no PEP8 issues in the file pandas/core/indexes/datetimes.py !

• There are no PEP8 issues in the file pandas/core/internals/blocks.py !

• There are no PEP8 issues in the file pandas/core/internals/managers.py !

• There are no PEP8 issues in the file pandas/core/reshape/reshape.py !

• There are no PEP8 issues in the file pandas/tests/extension/base/reshaping.py !

• There are no PEP8 issues in the file pandas/util/testing.py !

[codecov]

Codecov Report

Merging #24163 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24163      +/-   ##
==========================================
+ Coverage    92.2%    92.2%   +<.01%     
==========================================
  Files         162      162              
  Lines       51700    51712      +12     
==========================================
+ Hits        47670    47682      +12     
  Misses       4030     4030

Flag	Coverage Δ
#multiple	90.6% <100%> (ø)	⬆️
#single	43.03% <50%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	87.41% <100%> (ø)	⬆️
pandas/core/internals/managers.py	95.93% <100%> (+0.01%)	⬆️
pandas/core/internals/blocks.py	93.67% <100%> (+0.02%)	⬆️
pandas/core/reshape/reshape.py	99.56% <100%> (ø)	⬆️
pandas/core/base.py	97.64% <100%> (ø)	⬆️
pandas/core/indexes/datetimes.py	96.34% <100%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c911151...7c22e92. Read the comment docs.

[codecov]

Codecov Report

Merging #24163 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24163      +/-   ##
==========================================
+ Coverage    92.2%    92.2%   +<.01%     
==========================================
  Files         162      162              
  Lines       51700    51712      +12     
==========================================
+ Hits        47670    47682      +12     
  Misses       4030     4030

Flag	Coverage Δ
#multiple	90.6% <100%> (ø)	⬆️
#single	43.03% <50%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	87.41% <100%> (ø)	⬆️
pandas/core/internals/managers.py	95.93% <100%> (+0.01%)	⬆️
pandas/core/internals/blocks.py	93.67% <100%> (+0.02%)	⬆️
pandas/core/reshape/reshape.py	99.56% <100%> (ø)	⬆️
pandas/core/base.py	97.64% <100%> (ø)	⬆️
pandas/core/indexes/datetimes.py	96.34% <100%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c911151...7c22e92. Read the comment docs.

[jreback]

lgtm

[TomAugspurger]

Only failure was the Azure lining, which has since been fixed on master.

@jorisvandenbossche IIRC, you preferred that Series[period].values would return an ndarray of objects right?

[jorisvandenbossche]

you preferred that Series[period].values would return an ndarray of objects right?

That might be :-) In any case, since then we added array, so I think the rationale to keep .values backward compatible makes sense.

[TomAugspurger]

Sounds good. Merging.