-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: update usage of randn in io.rst #24154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @charlesdong1991
Codecov Report
@@ Coverage Diff @@
## master #24154 +/- ##
==========================================
- Coverage 92.2% 92.2% -0.01%
==========================================
Files 162 162
Lines 51700 51700
==========================================
- Hits 47671 47670 -1
- Misses 4029 4030 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24154 +/- ##
===========================================
+ Coverage 43.02% 92.2% +49.17%
===========================================
Files 162 162
Lines 51700 51700
===========================================
+ Hits 22245 47670 +25425
+ Misses 29455 4030 -25425
Continue to review full report at Codecov.
|
@charlesdong1991 the azure CI is red, can you fix the error please
|
@charlesdong1991 not sure why you undid the commit that fixed the PEP8 error, but we need it to merge this. CI is failing because of it. |
ahh, @datapythonista , sorry, since in the last submit, the error was caused by |
master was broken, and in those cases you can just wait until we fix it then merge master and push again You may have to merge the latest master to make the CI pass here, not sure. |
thanks, @datapythonista , get it! If the tests fail again, I will merge the latest master and push again. |
a04e317
to
6d0622c
Compare
thanks @charlesdong1991 |
git diff upstream/master -u -- "*.py" | flake8 --diff