Skip to content

DOC: update usage of randn in io.rst #24154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2018

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 commented Dec 7, 2018

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @charlesdong1991

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #24154 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24154      +/-   ##
==========================================
- Coverage    92.2%    92.2%   -0.01%     
==========================================
  Files         162      162              
  Lines       51700    51700              
==========================================
- Hits        47671    47670       -1     
- Misses       4029     4030       +1
Flag Coverage Δ
#multiple 90.6% <ø> (-0.01%) ⬇️
#single 43.02% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 93.65% <0%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67faf6c...cf97d7d. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #24154 into master will increase coverage by 49.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24154       +/-   ##
===========================================
+ Coverage   43.02%    92.2%   +49.17%     
===========================================
  Files         162      162               
  Lines       51700    51700               
===========================================
+ Hits        22245    47670    +25425     
+ Misses      29455     4030    -25425
Flag Coverage Δ
#multiple 90.6% <ø> (?)
#single 43.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.3% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 93.24% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 58.3% <0%> (+8.1%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/api.py 100% <0%> (+14.81%) ⬆️
pandas/core/indexes/api.py 99% <0%> (+14.85%) ⬆️
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update defa8a8...6d0622c. Read the comment docs.

@datapythonista
Copy link
Member

@charlesdong1991 the azure CI is red, can you fix the error please

doc/source/io.rst(4153,83): error E501: line too long (87 > 79 characters)

@datapythonista
Copy link
Member

@charlesdong1991 not sure why you undid the commit that fixed the PEP8 error, but we need it to merge this. CI is failing because of it.

@charlesdong1991
Copy link
Member Author

charlesdong1991 commented Dec 8, 2018

ahh, @datapythonista , sorry, since in the last submit, the error was caused by metadata in developer.rst, and i didn't know why it was related to my change here, so i undid the commit to verify it... looks like it's unrelated, and i saw other PRs, and some of them have the same problem, probably something was wrong in master ( and seems master is healthy now)... so this time i added the change back to fix linting error, should pass the all tests now... sorry for this... i should have clarified in the commit, my last commit was just my experiment to find why it's failing...

@datapythonista
Copy link
Member

master was broken, and in those cases you can just wait until we fix it then merge master and push again

You may have to merge the latest master to make the CI pass here, not sure.

@charlesdong1991
Copy link
Member Author

charlesdong1991 commented Dec 8, 2018

thanks, @datapythonista , get it! If the tests fail again, I will merge the latest master and push again.

@jreback jreback added this to the 0.24.0 milestone Dec 9, 2018
@jreback jreback merged commit 93e9be6 into pandas-dev:master Dec 9, 2018
@jreback
Copy link
Contributor

jreback commented Dec 9, 2018

thanks @charlesdong1991

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: update usage of randn in io.rst
3 participants