WIP/CI: Clean up to test calls #24106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of calling pytest twice, and renaming single to serial to keep consistency with pytest
datapythonista
added
Testing
|
Hello @datapythonista! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 29, 2018 at 12:35 Hours UTC |
datapythonista
changed the title
…be suprisingly slower. Restoing --strict-data-files too
…ce travis vs azure, and single vs multi-core
…ript, so it's always printed in any CI
…e same exact parameters as before now)
…nning slow tests when it's not intended)
|
Is this still active? |
|
yes, I need to investigate why tests are taking longer in this branch, which is weird, but would be great to have this merged after that, it cleans the CI configuration significantly |
|
closing as stale. |
This was referenced Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: As single tests do not fail in a deterministic way, I'll rerun the CI several times to see that the
--distoption is fixing the concurrency problems as expected.--dist=loadscopeinstead of calling pytest twice to not runsingletests in parallelsinglemarker toserialto keep consistency with pytest namingpytestcommon arguments tosetup.cfgso they don't need to be repeated in every call in the CI or in the local environmentspytestwith the parameters added tosetup.cfgrun_testsscript multiplatform by reimplementing it in Python, so all the calls are the same (which avoids duplicate code, and could allow changing the test locale in Windows)