-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Corrects 'reindex_axis' docstring #24105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
34e5fc6
Corrects 'reindex_axis' docstring.
eahogue 1208e50
Merge pull request #1 from eahogue/eahogue-patch-1
eahogue ffbad45
Minor PEP-8 change to previous commit
eahogue b54ea1d
Fixed non-functioning example.
eahogue 43f73dd
Update pandas/core/generic.py
datapythonista dacc3d3
Update pandas/core/generic.py
datapythonista 5b46081
Update pandas/core/generic.py
datapythonista d610339
Mostly stylistic updates to reindex_axis docstring.
eahogue c11052d
Adding deprecation note to reindex_axis docstring.
eahogue 963a31d
Merge branch 'master' into master
eahogue 0a8456c
Minor lint fixes for line length and trailing spaces.
eahogue 822dca1
Merge branch 'master' of https://github.com/eahogue/pandas
eahogue 201ef53
move deprecated
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reindex_axis
is a deprecated method, so it would be good to add aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have added this to the end of the summary. Based on other docstrings it looks like that's the place to put it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that looks good!