Skip to content

Check import warning #24102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Conversation

TomAugspurger
Copy link
Contributor

We usually catch uses of deprecated modules, but I think this may have slipped through since it's at import time.

@pep8speaks
Copy link

Hello @TomAugspurger! Thanks for submitting the PR.

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Dec 4, 2018
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #24102 into master will increase coverage by 49.2%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24102      +/-   ##
==========================================
+ Coverage      43%    92.2%   +49.2%     
==========================================
  Files         161      161              
  Lines       51684    51686       +2     
==========================================
+ Hits        22228    47659   +25431     
+ Misses      29456     4027   -25429
Flag Coverage Δ
#multiple 90.6% <75%> (?)
#single 43% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 85.27% <100%> (+51.22%) ⬆️
pandas/compat/__init__.py 58.3% <50%> (+8.1%) ⬆️
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.3% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 93.24% <0%> (+4.05%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5f4d1...2091770. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #24102 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24102      +/-   ##
==========================================
- Coverage   92.21%    92.2%   -0.01%     
==========================================
  Files         161      161              
  Lines       51684    51686       +2     
==========================================
+ Hits        47658    47659       +1     
- Misses       4026     4027       +1
Flag Coverage Δ
#multiple 90.6% <75%> (-0.01%) ⬇️
#single 43% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 85.27% <100%> (ø) ⬆️
pandas/compat/__init__.py 58.3% <50%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5f4d1...2091770. Read the comment docs.

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Dec 5, 2018
@jreback jreback merged commit d8d114c into pandas-dev:master Dec 5, 2018
@jreback
Copy link
Contributor

jreback commented Dec 5, 2018

thanks @TomAugspurger

@jreback jreback added the CI Continuous Integration label Dec 5, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants