Skip to content

TST: Work around statsmodels bug #24090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

TST: Work around statsmodels bug #24090

merged 1 commit into from
Dec 4, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #24088

@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite CI Continuous Integration labels Dec 4, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Dec 4, 2018
@pep8speaks
Copy link

Hello @TomAugspurger! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #24090 into master will increase coverage by 49.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24090       +/-   ##
===========================================
+ Coverage   42.52%   92.26%   +49.73%     
===========================================
  Files         161      161               
  Lines       51697    51697               
===========================================
+ Hits        21982    47696    +25714     
+ Misses      29715     4001    -25714
Flag Coverage Δ
#multiple 90.66% <ø> (?)
#single 42.52% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.3% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 93.24% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 58.36% <0%> (+8.17%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/api.py 100% <0%> (+14.81%) ⬆️
pandas/core/indexes/api.py 99% <0%> (+14.85%) ⬆️
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e96d8...b34b933. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 4, 2018 •
edited
Loading

Codecov Report

Merging #24090 into master will increase coverage by 49.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24090       +/-   ##
===========================================
+ Coverage   42.52%   92.26%   +49.73%     
===========================================
  Files         161      161               
  Lines       51697    51697               
===========================================
+ Hits        21982    47696    +25714     
+ Misses      29715     4001    -25714
Flag Coverage Δ
#multiple 90.66% <ø> (?)
#single 42.52% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.3% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 93.24% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 58.36% <0%> (+8.17%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/api.py 100% <0%> (+14.81%) ⬆️
pandas/core/indexes/api.py 99% <0%> (+14.85%) ⬆️
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e96d8...b34b933. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

cc @jreback. Merging in a little bit since this is causing CI failures.

@jreback jreback merged commit 1d3ed91 into pandas-dev:master Dec 4, 2018
@jreback
Copy link
Contributor

jreback commented Dec 4, 2018

yep looks good

@jreback
Copy link
Contributor

jreback commented Dec 4, 2018

I think this is failing all of the azure builds: ttps://dev.azure.com/pandas-dev/pandas/_build/results?buildId=4678 (I don't have my computer today, otherwise would fix :>)

@datapythonista

@TomAugspurger
Copy link
Contributor Author

Will do a PR on that quick.

@TomAugspurger TomAugspurger deleted the ci-fixup branch December 4, 2018 15:27
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Dec 4, 2018
@TomAugspurger
TST: Work around statsmodels bug (pandas-dev#24090)
67a9cf9
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
TST: Work around statsmodels bug (pandas-dev#24090)
d1c74fa
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
TST: Work around statsmodels bug (pandas-dev#24090)
70a10d5
jbrockmendel
jbrockmendel reviewed Apr 29, 2020
View reviewed changes
pandas/tests/plotting/test_datetimelike.py
@@ -1557,7 +1557,10 @@ def _check_plot_works(f, freq=None, series=None, *args, **kwargs):
# GH18439
# this is supported only in Python 3 pickle since
# pickle in Python2 doesn't support instancemethod pickling
if PY3:
# TODO(statsmodels 0.10.0): Remove the statsmodels check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TomAugspurger @pep8speaks @jreback @jbrockmendel