Skip to content

Handle utc and box parameters for to_datetime #24082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from

Conversation

jzhaojieh
Copy link

@pep8speaks
Copy link

pep8speaks commented Dec 3, 2018

Hello @jzhaojieh! Thanks for updating the PR.

Line 18:49: W291 trailing whitespace
Line 19:13: E128 continuation line under-indented for visual indent
Line 26:49: W291 trailing whitespace
Line 27:13: E128 continuation line under-indented for visual indent
Line 34:49: W291 trailing whitespace
Line 35:13: E128 continuation line under-indented for visual indent
Line 37:54: W291 trailing whitespace
Line 38:13: E128 continuation line under-indented for visual indent

Comment last updated on December 04, 2018 at 16:25 Hours UTC

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #24082 into master will decrease coverage by <.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24082      +/-   ##
==========================================
- Coverage   42.38%   42.38%   -0.01%     
==========================================
  Files         161      161              
  Lines       51701    51707       +6     
==========================================
  Hits        21914    21914              
- Misses      29787    29793       +6
Flag Coverage Δ
#single 42.38% <11.11%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 32.42% <0%> (-0.4%) ⬇️
pandas/core/dtypes/concat.py 55.71% <25%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08395af...004fb26. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #24082 into master will increase coverage by 49.87%.
The diff coverage is 98.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24082       +/-   ##
===========================================
+ Coverage   42.38%   92.25%   +49.87%     
===========================================
  Files         161      161               
  Lines       51701    51693        -8     
===========================================
+ Hits        21914    47691    +25777     
+ Misses      29787     4002    -25785
Flag Coverage Δ
#multiple 90.66% <98.14%> (?)
#single 42.5% <57.4%> (+0.12%) ⬆️
Impacted Files Coverage Δ
pandas/core/dtypes/common.py 95.62% <ø> (+25.23%) ⬆️
pandas/core/arrays/datetimelike.py 96.34% <100%> (+45.91%) ⬆️
pandas/core/arrays/datetimes.py 98.43% <100%> (+34.63%) ⬆️
pandas/core/internals/blocks.py 93.69% <100%> (+41.32%) ⬆️
pandas/core/dtypes/missing.py 93.1% <100%> (+35.63%) ⬆️
pandas/core/tools/datetimes.py 85.45% <100%> (+52.63%) ⬆️
pandas/core/dtypes/dtypes.py 95.33% <97.14%> (+19.17%) ⬆️
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.3% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 93.24% <0%> (+4.05%) ⬆️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08395af...4fcd2c4. Read the comment docs.

@jzhaojieh jzhaojieh changed the title Attempt fix Handle utc and box parameters for to_datetime Dec 4, 2018
@mroeschke
Copy link
Member

Thanks for the pull request. Looks like you pulled in some changes from other PRs. Could you limit this branch to the specific fix?

@gfyoung gfyoung added Bug Datetime Datetime data dtype labels Dec 6, 2018
@jreback
Copy link
Contributor

jreback commented Dec 23, 2018

pls merge master

@mroeschke
Copy link
Member

Closed by #24407

@mroeschke mroeschke closed this Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_datetime with unit mapping ignores utc and box arguments
9 participants