Docs for Panel4D/panelnd and Minor Enhancements #2407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
updated whatsnew/RELEASE removed old variable in panel creation (was for a previous version) all tests pass
bug in _get_plane_axes definition in panelnd updated to docs of panel4d to list currenctly disabled methods
…ping array, now -1 * self
update RELEAST.rst about comparison ops in Panel
| @@ -742,7 +825,10 @@ def reindex(self, major=None, minor=None, method=None, | |||
| if (method is None and not self._is_mixed_type and al <= 3): | |||
| items = kwargs.get('items') | |||
| if com._count_not_none(items, major, minor) == 3: | |||
| return self._reindex_multi(items, major, minor) | |||
| try: | |||
There was a problem hiding this comment.
try: except: added because this broke on boolean operations in com.take_multi_2d - so will have to revist at somepoint
|
travis build is good - ready to merge |
Closed
|
great....fyi...there seems to be a weird bolding in RELEAST.rst (in experimental features).... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated whatsnew/RELEASE
added boolean comparison methods to panel.py (didn't exist before)
all tests pass
need to update the link to dsintro-panel4d section in the whatsnew docs....