-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix quotes position in Series docstrings #24065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix quotes position in Series docstrings #24065
Conversation
It's not done yet... for some, i did change the docstring, and i expect the output to change correspondingly, but result doesn't.. still need to find where the problem is... e.g. |
Codecov Report
@@ Coverage Diff @@
## master #24065 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 161 161
Lines 51562 51562
=======================================
Hits 47599 47599
Misses 3963 3963
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24065 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 161 161
Lines 51562 51562
=======================================
Hits 47599 47599
Misses 3963 3963
Continue to review full report at Codecov.
|
@datapythonista is there a lint rule to enforce this? |
yes, we've got |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks a lot for working on this @charlesdong1991
It's not something to address in this PR, but I created #24068 to avoid adding the \n
to the _field_accessor
parameters.
@datapythonista yeah... indeed, i was thinking to add line breaks for docstring |
We'll focus on the special cases once we have the rest fixed. There were around 250 wrong cases of the error you've been fixing. I'll open an issue for the remaining once this is merged. |
thanks @charlesdong1991 |
@datapythonista ok, i could push the new change for the |
sure, can you open another PR for it? And if you can check the the calls to |
git diff upstream/master -u -- "*.py" | flake8 --diff