-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: run setitem tests for IntegerArray #24054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @jreback! Thanks for submitting the PR.
|
noticed this when merging #23991 @TomAugspurger is |
Codecov Report
@@ Coverage Diff @@
## master #24054 +/- ##
=========================================
Coverage ? 42.44%
=========================================
Files ? 161
Lines ? 51564
Branches ? 0
=========================================
Hits ? 21887
Misses ? 29677
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24054 +/- ##
===========================================
+ Coverage 42.38% 92.25% +49.86%
===========================================
Files 161 161
Lines 51699 51701 +2
===========================================
+ Hits 21913 47696 +25783
+ Misses 29786 4005 -25781
Continue to review full report at Codecov.
|
Probably want to add a docstring for your LGTM otherwise. |
not sure why azure is not running on the personal builds. but this is ready @TomAugspurger |
Agreed. We may want to hold off on merging larger changes, since I believe linting is now on azure, but this LGTM. |
But let's see if it runs for the merge build. If so, then we can merge things and followup as needed. |
* TST: run setitem tests for IntegerArray * doc-string
* TST: run setitem tests for IntegerArray * doc-string
No description provided.