Skip to content

DOC: Stop ignoring fixed rst files in flake8-rst #24051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 3, 2018
Merged

DOC: Stop ignoring fixed rst files in flake8-rst #24051

merged 6 commits into from
Dec 3, 2018

Conversation

datapythonista
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Removing from the list of ignored files in flake8-rst, the pages that have been fixed before the ignore list was merged.

@datapythonista datapythonista added Docs Code Style Code style, linting, code_checks labels Dec 2, 2018
This was referenced Dec 2, 2018
Merged
Merged
FHaase
FHaase reviewed Dec 2, 2018
View reviewed changes
setup.cfg
doc/source/contributing.rst
doc/source/contributing_docstring.rst
doc/source/dsintro.rst
doc/source/enhancingperf.rst
doc/source/extending.rst
doc/source/groupby.rst
doc/source/indexing.rst
doc/source/io.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io.rst isn't yet completely fixed.

setup.cfg Outdated
doc/source/contributing.rst
doc/source/contributing_docstring.rst
doc/source/dsintro.rst
doc/source/enhancingperf.rst
doc/source/extending.rst
doc/source/groupby.rst
doc/source/indexing.rst
doc/source/io.rst
doc/source/merging.rst
doc/source/missing_data.rst
doc/source/options.rst
doc/source/release.rst
doc/source/reshaping.rst
doc/source/timedeltas.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timedeltas.rst can also be removed

@codecov
Copy link

codecov bot commented Dec 2, 2018 •
edited
Loading

Codecov Report

Merging #24051 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24051   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         161      161           
  Lines       51562    51562           
=======================================
  Hits        47599    47599           
  Misses       3963     3963
Flag Coverage Δ
#multiple 90.71% <ø> (ø) ⬆️
#single 42.44% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 022f458...707d823. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@92d25f0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #24051   +/-   ##
=========================================
  Coverage          ?   42.45%           
=========================================
  Files             ?      161           
  Lines             ?    51561           
  Branches          ?        0           
=========================================
  Hits              ?    21888           
  Misses            ?    29673           
  Partials          ?        0
Flag Coverage Δ
#single 42.45% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d25f0...563007b. Read the comment docs.

@datapythonista
Copy link
Member Author

thanks for the comments @FHaase, I fixed the remaining issues in io.rst and stopped ignoring timedeltas.rst

@jreback
Copy link
Contributor

jreback commented Dec 2, 2018

@datapythonista can you rebase this. (i merged something else)

@jreback jreback added this to the 0.24.0 milestone Dec 2, 2018
@datapythonista
Copy link
Member Author

@jreback this is green now

@jreback jreback merged commit 8b0f9b3 into pandas-dev:master Dec 3, 2018
@jreback
Copy link
Contributor

jreback commented Dec 3, 2018

thanks!

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@datapythonista @Pingviinituutti
DOC: Stop ignoring fixed rst files in flake8-rst (pandas-dev#24051)
9a3f5e0
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@datapythonista @Pingviinituutti
DOC: Stop ignoring fixed rst files in flake8-rst (pandas-dev#24051)
a373ede
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FHaase FHaase FHaase left review comments

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@datapythonista @jreback @FHaase