Duplicate PR of #22854 (testing publishing docs from azure) #24030

datapythonista · 2018-12-01T01:27:34Z

Publishing the docs from azure only works for changes that do not come from a fork. This PR is from a branch in the same pandas repo, to test that publishing works. But once confirmed that the publishing works, I'll close it, and the changes will be merged in #22854.

…s that used to be loops). Installing missing packages, splitting linting and checks, and continuing on errors

…when lines are found (exit 0)

… with or without quotes

… seems to fail because of it

…of script solves the exclamation mark problems

…pep8 issue in scripts/tests

…tion, which runs the task, but doesn't change the outcome of the build

…nd it shows them without having to enter the log)

…ving to the command for now

…with errors to see how they look

…d there too

…cessible

… not running publishing docs to github pages

…cia/miniconda3/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/mgarcia/.local/bin:/home/mgarcia/bin problem

This reverts commit 59d55d8.

… commit to master and not a PR

…in a PR from the same pandas repo)

pep8speaks · 2018-12-01T01:27:39Z

Hello @datapythonista! Thanks for updating the PR.

There are no PEP8 issues in the file pandas/core/frame.py !
In the file pandas/core/panel.py, following are the PEP8 issues :

Line 1042:13: E731 do not assign a lambda expression, use a def
Line 1168:9: E731 do not assign a lambda expression, use a def

There are no PEP8 issues in the file pandas/core/tools/timedeltas.py !
In the file pandas/core/window.py, following are the PEP8 issues :

Line 1380:13: E731 do not assign a lambda expression, use a def

There are no PEP8 issues in the file pandas/io/gbq.py !
In the file pandas/io/json/json.py, following are the PEP8 issues :

Line 893:13: E731 do not assign a lambda expression, use a def

There are no PEP8 issues in the file scripts/generate_pip_deps_from_conda.py !

Comment last updated on December 01, 2018 at 02:25 Hours UTC

codecov · 2018-12-01T02:25:00Z

Codecov Report

Merging #24030 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24030      +/-   ##
==========================================
- Coverage   42.46%   42.42%   -0.04%     
==========================================
  Files         161      161              
  Lines       51557    51623      +66     
==========================================
+ Hits        21892    21903      +11     
- Misses      29665    29720      +55

Flag	Coverage Δ
#single	`42.42% <100%> (-0.04%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/panel.py	`42.02% <ø> (ø)`	⬆️
pandas/core/tools/timedeltas.py	`66.66% <ø> (ø)`	⬆️
pandas/core/frame.py	`38.7% <ø> (ø)`	⬆️
pandas/io/json/json.py	`16.66% <ø> (ø)`	⬆️
pandas/io/gbq.py	`25% <ø> (ø)`	⬆️
pandas/core/window.py	`28.93% <100%> (ø)`	⬆️
pandas/core/reshape/tile.py	`13.02% <0%> (+1.39%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa547d8...75b89eb. Read the comment docs.

codecov · 2018-12-01T02:25:01Z

Codecov Report

Merging #24030 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24030      +/-   ##
==========================================
- Coverage   42.46%   42.42%   -0.04%     
==========================================
  Files         161      161              
  Lines       51557    51623      +66     
==========================================
+ Hits        21892    21903      +11     
- Misses      29665    29720      +55

Flag	Coverage Δ
#single	`42.42% <100%> (-0.04%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/panel.py	`42.02% <ø> (ø)`	⬆️
pandas/core/tools/timedeltas.py	`66.66% <ø> (ø)`	⬆️
pandas/io/gbq.py	`25% <ø> (ø)`	⬆️
pandas/core/frame.py	`38.7% <ø> (ø)`	⬆️
pandas/io/json/json.py	`16.66% <ø> (ø)`	⬆️
pandas/core/window.py	`28.93% <100%> (ø)`	⬆️
pandas/core/reshape/tile.py	`13.02% <0%> (+1.39%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa547d8...75b89eb. Read the comment docs.

datapythonista · 2018-12-01T11:17:04Z

Couldn't make the publishing to azure work, but for now we'll leave it in travis and github pages.

datapythonista added 30 commits September 27, 2018 14:21

Moving one-line linting and checks from lint.sh to azure steps

46620f2

Moving everything from lint.sh to azure (so far repeating the command…

dc8c528

…s that used to be loops). Installing missing packages, splitting linting and checks, and continuing on errors

Fixing continueOnError settings

adeb0ca

Reverting the exit status of the grep commands, we want them to fail …

dcfb203

…when lines are found (exit 0)

Testing the continueOnError, doesn't seem to be working at job level,…

b765df8

… with or without quotes

Escaping exclamation marks to reverse the exist status of grep, azure…

3c77fc9

… seems to fail because of it

Adding the continueOnError to every step, and trying if bash instead …

3d8af7d

…of script solves the exclamation mark problems

Fixes to missing continueOnError, and to the grep command exit status

ed1064d

Testing couple of ways to invert the exit status of grep

8cb7b0f

Fixing azure config syntax error

dee5a08

Fixing the checks (they should be ok now), and adding an intentional …

54f9e98

…pep8 issue in scripts/tests

Removing intentional pep8 issue, and fixing last known problems

20cb360

fixing style of azure settings

50d2757

Replacing continueOnError (that converts errors in warnings) to condi…

19a213c

…tion, which runs the task, but doesn't change the outcome of the build

Fixing multiline in yaml, and removing job level continueOnError

0cf5da9

Changing the format of flake8 output to azure (so it creates links, a…

4d10702

…nd it shows them without having to enter the log)

Removing unnecessary quotes in flake8 format config

a356f03

flake8 format breaks pip (ConfigParser) when present in setup.cfg, mo…

50cb867

…ving to the command for now

Adding azure formatting to all failing flake8

091193c

Merging from master

4a2ddba

Fixing azure job name

e7c276a

Making the format look good for flake8 and patterns, and adding file …

8f73c08

…with errors to see how they look

Trying if environment variables can be defined in the script setting

87b5048

Merging from master

dc2e3a6

Removing file with errors to be displayed, and comment in the setup.cfg

5ab03ab

Changing cython cast grep to invgrep

ca9e12a

Merging from master

c591a17

Building source of the checks build and moving the documentation buil…

c671da5

…d there too

Adding dependencies file for the checks and doc build

a6eed3e

Renaming conda yaml env variable

3b853f9

datapythonista added 23 commits November 23, 2018 01:07

Clean up of debug info

a225d44

Uploading docs to GitHub pages in the same way as travis

d6d5c66

Adding variable group to the job config, to see if that makes them ac…

f7a6048

…cessible

WIP: Restoring travis documentation build

9aa18d0

Restoing documentation build in travis

283233d

Removing variable group, as variables are not in a group anymore, and…

991304d

… not running publishing docs to github pages

Merge remote-tracking branch 'upstream/master' into azure_lint

3a71185

Adding missing conda environment activation

19c396f

Fixing docstring errors

a69e667

Removing documentation build from azure

59d55d8

Merge remote-tracking branch 'upstream/master' into azure_lint

df50c58

Adding debug info to diagnose /home/mgarcia/miniconda3/bin:/home/mgar…

455e77c

…cia/miniconda3/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/mgarcia/.local/bin:/home/mgarcia/bin problem

adding more debug information

7f48ac2

Revert "Removing documentation build from azure"

078a987

This reverts commit 59d55d8.

Clean up of debug commands

d7883a1

Removing doc build in azure (restored because of the path problem)

c2be491

Building docs in azure, and uploading them to azure storage if it's a…

910825a

… commit to master and not a PR

Merge remote-tracking branch 'upstream/master' into azure_lint

35c7d99

Merging from master

d321a42

Fixing pending docstrings

4328b04

Updating dependencies with the version that fixes the speed problems

4c57f48

Updating pip requirements

497f032

Always uploading docs (removed if to test if uploading the docs work …

c88911a

…in a PR from the same pandas repo)

Adding parallelization to build and docs

75b89eb

datapythonista closed this Dec 1, 2018

datapythonista deleted the azure_lint branch December 5, 2018 23:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Duplicate PR of #22854 (testing publishing docs from azure) #24030

Duplicate PR of #22854 (testing publishing docs from azure) #24030

datapythonista commented Dec 1, 2018

pep8speaks commented Dec 1, 2018 •

edited

Loading

codecov bot commented Dec 1, 2018

codecov bot commented Dec 1, 2018 •

edited

Loading

datapythonista commented Dec 1, 2018

Duplicate PR of #22854 (testing publishing docs from azure) #24030

Duplicate PR of #22854 (testing publishing docs from azure) #24030

Conversation

datapythonista commented Dec 1, 2018

pep8speaks commented Dec 1, 2018 • edited Loading

Comment last updated on December 01, 2018 at 02:25 Hours UTC

codecov bot commented Dec 1, 2018

Codecov Report

codecov bot commented Dec 1, 2018 • edited Loading

Codecov Report

datapythonista commented Dec 1, 2018

pep8speaks commented Dec 1, 2018 •

edited

Loading

codecov bot commented Dec 1, 2018 •

edited

Loading