DEPS: Pinning versions of some dependencies to speed up environment creation #24015
Conversation
…t makes solving the environment take around 45 minutes
|
nice! I'm glad this works. I'll use this as an example for others until we get conda sorted out. |
|
Thanks for tracking this down @datapythonista. I'm perfectly happy with pinning and removing some optional deps for the dev env. Feel free to merge once you've verified that the solver is performing well on the CI. |
|
Wouldn't it work to just use |
|
@TomAugspurger the CI is not using @h-vetinari I guess that should work to, and will make newer versions installed (and I assume by the time we could have too many dependencies again, conda will be fixes). I'll give it a try and see. |
Codecov Report
@@ Coverage Diff @@
## master #24015 +/- ##
===========================================
- Coverage 92.31% 42.46% -49.85%
===========================================
Files 161 161
Lines 51549 51556 +7
===========================================
- Hits 47586 21892 -25694
- Misses 3963 29664 +25701
Continue to review full report at Codecov.
|
|
where was this showing up? |
|
I really don't like pinning things, because they are then never unpinned |
|
While I agree, I find this to be a very practical stopgap until we at Anaconda can fix the conda behavior issue. |
|
And keep in mind that this is just for the dev environment.yml, not for any
of the CI jobs.
…On Fri, Nov 30, 2018 at 10:04 AM Marc Garcia ***@***.***> wrote:
@jreback <https://github.com/jreback> you can see the "Checks and docs"
azure job timing out (or taking a lot of time to complete) here: #22854
<#22854>
Also, if you try to recreate your local environment using environment.yml
you should experience the same (in Linux, in Mac seems like it worked for
Tom)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24015 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIoX3iX_4AjMChZ73E_M9YMxPLTj8ks5u0Vb4gaJpZM4Y7yYw>
.
|
environment.yml
Outdated
| - flake8 | ||
| - flake8-comprehensions | ||
| - flake8-rst=0.4.2 | ||
| - gitpython | ||
| - hypothesis>=3.58.0 | ||
| - hypothesis=3.82 |
There was a problem hiding this comment.
can you make these >= (for all)? does this solve things
There was a problem hiding this comment.
meaning, does it affect the solving speed
|
I checked it, and the speed looks the same when using |
|
Thanks! |
…reation (pandas-dev#24015) * DEPS: Pinning versions of some dependencies, to fix conda problem that makes solving the environment take around 45 minutes * Making pinned dependencies versions greater or equal, instead of just equal
…reation (pandas-dev#24015) * DEPS: Pinning versions of some dependencies, to fix conda problem that makes solving the environment take around 45 minutes * Making pinned dependencies versions greater or equal, instead of just equal
git diff upstream/master -u -- "*.py" | flake8 --diffConda is taking 45 minutes to create an environment with our
environment.yml. While this is a bug in conda, it won't be fixed until the next version. So, a workaround for now is to pin the verion of some of the packages.I'm also removing couple of packages that I don't think are useful in a local environment, or in the CI build that will use the file (for the linting and to build the docs).