API: fix str-accessor on CategoricalIndex #24005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @h-vetinari! Thanks for submitting the PR.
|
gfyoung
added
Bug
Indexing
gfyoung
reviewed
Nov 30, 2018
doc/source/whatsnew/v0.24.0.rst
Outdated
| @@ -1254,6 +1254,7 @@ Categorical | |||
| - Bug in :meth:`Categorical.take` with a user-provided ``fill_value`` not encoding the ``fill_value``, which could result in a ``ValueError``, incorrect results, or a segmentation fault (:issue:`23296`). | |||
| - In meth:`Series.unstack`, specifying a ``fill_value`` not present in the categories now raises a ``TypeError`` rather than ignoring the ``fill_value`` (:issue:`23284`) | |||
| - Bug when resampling :meth:`Dataframe.resample()` and aggregating on categorical data, the categorical dtype was getting lost. (:issue:`23227`) | |||
| - Bug in the ``__name__`` attribute of several methods of :class:`Series.str`, which were set incorrectly (:issue:`23551`) | |||
There was a problem hiding this comment.
I'm confused...how does this entry relate to your other changes?
There was a problem hiding this comment.
Deleted the wrong line when splitting up #23167...
gfyoung
reviewed
Nov 30, 2018
pandas/tests/test_strings.py
Outdated
| @@ -264,6 +261,7 @@ def test_api_per_method(self, box, dtype, | |||
| + ['mixed', 'mixed-integer'] * mixed_allowed) | |||
|
|
|||
| if inferred_dtype in allowed_types: | |||
| # i.a. GH 23555, GH 23556 | |||
Codecov Report
@@ Coverage Diff @@
## master #24005 +/- ##
=======================================
Coverage 42.45% 42.45%
=======================================
Files 161 161
Lines 51561 51561
=======================================
Hits 21888 21888
Misses 29673 29673
Continue to review full report at Codecov.
|
3 tasks
jreback
requested changes
Dec 2, 2018
doc/source/whatsnew/v0.24.0.rst
Outdated
| @@ -1254,6 +1254,7 @@ Categorical | |||
| - Bug in :meth:`Categorical.take` with a user-provided ``fill_value`` not encoding the ``fill_value``, which could result in a ``ValueError``, incorrect results, or a segmentation fault (:issue:`23296`). | |||
| - In meth:`Series.unstack`, specifying a ``fill_value`` not present in the categories now raises a ``TypeError`` rather than ignoring the ``fill_value`` (:issue:`23284`) | |||
| - Bug when resampling :meth:`Dataframe.resample()` and aggregating on categorical data, the categorical dtype was getting lost. (:issue:`23227`) | |||
| - Bug in many methods of the ``.str``-accessor, which always failed on `CategoricalIndex` (:issue:`23555`, :issue:`23556`) | |||
pandas/core/strings.py
Outdated
|
|
||
| # for category, we do the stuff on the categories, so blow it up | ||
| # to the full series again | ||
| # But for some operations, we have to do the stuff on the full values, | ||
| # so make it possible to skip this step as the method already did this | ||
| # before the transformation... | ||
| if use_codes and self._is_categorical: | ||
| result = take_1d(result, self._orig.cat.codes, | ||
| # if self._orig is a CategoricalIndex, there is no .cat-accessor | ||
| result = take_1d(result, Series(self._orig).cat.codes, |
There was a problem hiding this comment.
you can use copy=False here in the Series construction
pandas/tests/test_strings.py
Outdated
| @@ -264,6 +261,7 @@ def test_api_per_method(self, box, dtype, | |||
| + ['mixed', 'mixed-integer'] * mixed_allowed) | |||
|
|
|||
| if inferred_dtype in allowed_types: | |||
| # inter alia GH 23555, GH 23556 | |||
jreback
requested changes
Dec 2, 2018
doc/source/whatsnew/v0.24.0.rst
Outdated
| @@ -1256,6 +1256,7 @@ Categorical | |||
| - Bug in :meth:`Categorical.take` with a user-provided ``fill_value`` not encoding the ``fill_value``, which could result in a ``ValueError``, incorrect results, or a segmentation fault (:issue:`23296`). | |||
| - In meth:`Series.unstack`, specifying a ``fill_value`` not present in the categories now raises a ``TypeError`` rather than ignoring the ``fill_value`` (:issue:`23284`) | |||
| - Bug when resampling :meth:`Dataframe.resample()` and aggregating on categorical data, the categorical dtype was getting lost. (:issue:`23227`) | |||
| - Bug in many methods of the ``.str``-accessor, which always failed on ``CategoricalIndex`` (:issue:`23555`, :issue:`23556`) | |||
There was a problem hiding this comment.
re-word this to say CategoricalIndex.str
There was a problem hiding this comment.
@jreback
Hope this is more like what you were after.
jreback
approved these changes
Dec 2, 2018
|
@jreback |
|
thanks @h-vetinari |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23555
closes #23556
split off from #23167
git diff upstream/master -u -- "*.py" | flake8 --diff