-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG/TST: PeriodArray.__setitem__ with slice and list-like value #23991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 14 commits into
pandas-dev:master
from
charlesdong1991:periodarray_listlike
Dec 2, 2018
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4385128
pytest for slice type in setitem
charlesdong1991 aacb769
remove wrong pytests
charlesdong1991 e19c381
new pytest in TestSetitem
charlesdong1991 b12f0bc
fix pytest error
charlesdong1991 6ca1f1a
remove a blank line to see if error disappear
charlesdong1991 f3db6c1
resort imports
charlesdong1991 fe74ea1
fix linting failure
charlesdong1991 0e19fdb
fix linting error
charlesdong1991 3e76a61
resort imports
charlesdong1991 ec8f68e
resort imports using isort
charlesdong1991 217146f
remove redundant blank line
charlesdong1991 74ea7b8
move to basesetitem
charlesdong1991 39a4807
remove unused package from import
charlesdong1991 6c9702e
add whatsnew description
charlesdong1991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
import pandas as pd | ||
from pandas.core.arrays import PeriodArray | ||
from pandas.tests.extension import base | ||
import pandas.util.testing as tm | ||
|
||
|
||
@pytest.fixture | ||
|
@@ -147,6 +148,7 @@ class TestReshaping(BasePeriodTests, base.BaseReshapingTests): | |
|
||
|
||
class TestSetitem(BasePeriodTests, base.BaseSetitemTests): | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this. |
||
pass | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably delete this