Skip to content

isort plotting, a handful of test dirs #23957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 28, 2018
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #23957 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23957   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         161      161           
  Lines       51471    51471           
=======================================
  Hits        47515    47515           
  Misses       3956     3956
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 42.43% <86.11%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_style.py 77.41% <100%> (ø) ⬆️
pandas/plotting/_converter.py 63.67% <100%> (ø) ⬆️
pandas/plotting/_tools.py 78.77% <100%> (ø) ⬆️
pandas/plotting/_compat.py 87.5% <100%> (ø) ⬆️
pandas/plotting/_core.py 83.63% <100%> (ø) ⬆️
pandas/plotting/_misc.py 38.68% <100%> (ø) ⬆️
pandas/plotting/_timeseries.py 65.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7cf48...82bc0f8. Read the comment docs.

@jreback jreback added the Code Style Code style, linting, code_checks label Nov 28, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 28, 2018
@jreback jreback merged commit db8d33e into pandas-dev:master Nov 28, 2018
@jreback
Copy link
Contributor

jreback commented Nov 28, 2018

thanks

@jbrockmendel jbrockmendel deleted the sort branch November 28, 2018 14:37
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants