BUG/ENH - base argument no longer ignored in period resample

[ms7463]

• closes BUG: base argument ignored in PeriodIndex resample #23882
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[pep8speaks]

Hello @ArtinSarraf! Thanks for updating the PR.

• There are no PEP8 issues in the file pandas/core/resample.py !

• There are no PEP8 issues in the file pandas/tests/resample/test_period_index.py !

Comment last updated on December 08, 2018 at 05:00 Hours UTC

[codecov]

Codecov Report

Merging #23941 into master will decrease coverage by <.01%.
The diff coverage is 91.3%.

@@            Coverage Diff             @@
##           master   #23941      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         162      162              
  Lines       51785    51805      +20     
==========================================
+ Hits        47758    47776      +18     
- Misses       4027     4029       +2

Flag	Coverage Δ
#multiple	90.62% <91.3%> (-0.01%)	⬇️
#single	42.99% <8.69%> (-0.02%)	⬇️

Impacted Files	Coverage Δ
pandas/core/resample.py	96.58% <91.3%> (-0.24%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c037128...c234cac. Read the comment docs.

[gfyoung]

Good start! Also needs a whatsnew entry.

[jreback]

this is a lint error

[ms7463]

@jreback - caught a bug in my original bin offset calculation. Previously it was only valid when the index started at the 0 base of the index's frequency. I've fixed that and added several test cases that previously would have failed.

[jreback]

can you merge master

[ms7463]

@mroeschke - reverted the changes here and added a new PR.
#24159

[ms7463]

@jreback / @mroeschke - anything else to consider?

[jreback]

looks good. just want some more docs.

[jreback]

thanks @ArtinSarraf