-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Change code-block to ipython in r_interface.rst #23906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Change code-block to ipython in r_interface.rst #23906
Conversation
The documentation mainly uses the `.. ipython::` directive. This changes the code-blocks to ipython blocks so there is a unified visual style. Signed-off-by: Fabian Haase <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case that the tests shouldn't be executed, I find the .. code-block:: python
clearer than the ipython
with outputs. But replacing the doctest: +SKIP
by the :verbatim:
looks good.
Codecov Report
@@ Coverage Diff @@
## master #23906 +/- ##
==========================================
+ Coverage 92.29% 92.29% +<.01%
==========================================
Files 161 161
Lines 51498 51500 +2
==========================================
+ Hits 47530 47533 +3
+ Misses 3968 3967 -1
Continue to review full report at Codecov.
|
I've decided to use a As there isn't a |
isn't the verbatim option enough for the tests to not be run? |
The
As the |
Ohh wait, you mean something like this:
This way the output is recognized as some more input lines. That's why I utilized the |
In this case we can't use It's not very important, but personally I'd use |
I like |
I think I asked you in another issue, but didn't yet understand. What's the reason you're using |
Ohh sorry, now I get what you mean. I was always concerned about the generated output.
Would render with |
Signed-off-by: Fabian Haase <[email protected]>
This reverts commit e0613b7 Signed-off-by: Fabian Haase <[email protected]>
Well using:
renders as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand your point now. I thought you were talking about the consistency in terms of the code, not in how it is presented to the user (I thought it was always rendered the same).
lgtm then, thanks @FHaase
thanks @FHaase |
The documentation mainly uses the
.. ipython::
directive. This changesthe code-blocks to ipython blocks so there is a unified visual style.