-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix PEP-8 issues in timedeltas.rst #23905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fabian Haase <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #23905 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 161 161
Lines 51498 51498
=======================================
Hits 47530 47530
Misses 3968 3968
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @FHaase
@jbrockmendel if you want to take a look here too
This looks fine to me. Only question is if the importing of Second/Minute etc is intentional. |
Not sure what you mean. Replacing the |
I would have a strong preference against |
Well if someone reads the documentation finding something like By writing |
thanks @FHaase yeah more explicit the better. |
Signed-off-by: Fabian Haase <[email protected]>
Signed-off-by: Fabian Haase <[email protected]>
from pandas.tseries.offsets import *
withpd.offsets.<ClassName>
for better readability.