-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix PEP-8 issues in groupby.rst #23900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fabian Haase <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just couple of small details
doc/source/groupby.rst
Outdated
@@ -938,7 +937,7 @@ that is itself a series, and possibly upcast the result to a DataFrame: | |||
.. ipython:: python | |||
|
|||
def f(x): | |||
return pd.Series([ x, x**2 ], index = ['x', 'x^2']) | |||
return pd.Series([x, x**2], index=['x', 'x^2']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't spaces required around the **
operator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow it doesn't complain, I changed it anyway.
Signed-off-by: Fabian Haase <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #23900 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 161 161
Lines 51498 51498
=======================================
Hits 47530 47530
Misses 3968 3968
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @FHaase
Thanks @FHaase ! Keep them coming! |
Signed-off-by: Fabian Haase <[email protected]>
Signed-off-by: Fabian Haase <[email protected]>
No description provided.