Skip to content

DOC: Fix PEP-8 issues in timeseries.rst #23898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2018

Conversation

FHaase
Copy link
Contributor

@FHaase FHaase commented Nov 25, 2018

  • Replace from pandas import offsets and from pandas.tseries.offsets import * with
    pd.offsets.<ClassName>.

@FHaase FHaase changed the title DOC: Fix PEP-8 issues in visualization.rst DOC: Fix PEP-8 issues in timeseries.rst Nov 25, 2018
@codecov
Copy link

codecov bot commented Nov 25, 2018

Codecov Report

Merging #23898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23898   +/-   ##
=======================================
  Coverage   42.46%   42.46%           
=======================================
  Files         161      161           
  Lines       51557    51557           
=======================================
  Hits        21892    21892           
  Misses      29665    29665
Flag Coverage Δ
#single 42.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45eb26...ed22297. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks @FHaase

@jbrockmendel do you mind to take a look and merge if you're happy

@datapythonista datapythonista added Docs Datetime Datetime data dtype Code Style Code style, linting, code_checks labels Nov 25, 2018
@mroeschke
Copy link
Member

Do you mind waiting until #23385 is merged?

@datapythonista
Copy link
Member

@FHaase can you fix the conflicts please?

# Conflicts:
#	doc/source/timeseries.rst
@jreback jreback added this to the 0.24.0 milestone Dec 2, 2018
@jreback jreback merged commit 9d85b22 into pandas-dev:master Dec 2, 2018
@jreback
Copy link
Contributor

jreback commented Dec 2, 2018

thanks @FHaase

@FHaase FHaase deleted the fix-pep8-timeseries branch December 2, 2018 19:30
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Datetime Datetime data dtype Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants