-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix format of advanced.rst according to PEP-8 standard #23893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23893 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 161 161
Lines 51498 51498
=======================================
Hits 47530 47530
Misses 3968 3968
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, added few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank @YuechengWu
The CI is green, if it doesn't work locally I guess it's because you miss some ipython dependency.
cool, thanks @datapythonista |
Thanks @YuechengWu ! |
@datapythonista : I presume it's safe now to turn on |
@gfyoung My pleasure! |
@datapythonista : Ah, right. Thanks for clarifying! |
git diff upstream/master -u -- "*.py" | flake8 --diff