Skip to content

Fix format of advanced.rst according to PEP-8 standard #23893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2018

Conversation

YuechengWu
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 25, 2018

Codecov Report

Merging #23893 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23893   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51498    51498           
=======================================
  Hits        47530    47530           
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.69% <ø> (ø) ⬆️
#single 42.43% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 97.02% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002ab43...5e724e7. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, added few comments

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank @YuechengWu

The CI is green, if it doesn't work locally I guess it's because you miss some ipython dependency.

@YuechengWu
Copy link
Contributor Author

cool, thanks @datapythonista

@gfyoung gfyoung added Docs Code Style Code style, linting, code_checks labels Nov 25, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 25, 2018
@gfyoung gfyoung merged commit 9afc21e into pandas-dev:master Nov 25, 2018
@gfyoung
Copy link
Member

gfyoung commented Nov 25, 2018

Thanks @YuechengWu !

@gfyoung
Copy link
Member

gfyoung commented Nov 25, 2018

@datapythonista : I presume it's safe now to turn on flake8-rst ?

@YuechengWu
Copy link
Contributor Author

@gfyoung My pleasure!

@datapythonista
Copy link
Member

@gfyoung we have flake8-rst activated, but the version we have doesn't check ipython blocks. We're upgrading the version in #23847, but we still have plenty of files to fix.

@gfyoung
Copy link
Member

gfyoung commented Nov 25, 2018

@datapythonista : Ah, right. Thanks for clarifying!

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix format of advanced.rst
3 participants