CLN: writers.pyx cdef cleanup #23880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What factors are you using to determine |
pandas/_libs/writers.pyx
Outdated
| ndarray[uint8_t] narr | ||
| unsigned char v, comma, left_bracket, right_brack, newline | ||
| ndarray[uint8_t, ndim=1] narr | ||
| unsigned char v, newline, comma, left_bracket, right_bracket, quote |
There was a problem hiding this comment.
LGTM. Only nitpick while we're here: can you change v to val just to avoid 1-character names
Codecov Report
@@ Coverage Diff @@
## master #23880 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 161 161
Lines 51498 51498
=======================================
Hits 47530 47530
Misses 3968 3968
Continue to review full report at Codecov.
|
gfyoung
reviewed
Nov 24, 2018
To add onto @WillAyd point, |
|
@WillAyd py_ssize_t is unsigned, is the suggested usage for length-like variables. |
|
@jbrockmendel it's size_t that is unsigned and Py_ssize_t is signed, no? https://www.python.org/dev/peps/pep-0353/ IIUC helps ensure cross-platform indexing can go beyond 2**31 that compilers may use for an int even on 64 bit platforms. That makes sense to me though I'd just be curious then if there's a reason we would choose this over say a |
|
The train of thought was, as @jbrockmendel mentioned, to use The pep mentiones No performance regressions when running the asvs: |
WillAyd
approved these changes
Nov 24, 2018
| @@ -23,7 +23,7 @@ ctypedef fused pandas_string: | |||
| @cython.boundscheck(False) | |||
| @cython.wraparound(False) | |||
| def write_csv_rows(list data, ndarray data_index, | |||
There was a problem hiding this comment.
Do we stand to gain anything by being more explicit about the type of the ndarrays here?
There was a problem hiding this comment.
I wasn't able to find a type for these ndarrays that passes the test suite. Should be okay as is.
|
thanks @mroeschke |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inttoPy_ssize_t