Skip to content

TST: Test .loc with uint64 numbers #23879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2018
Merged

TST: Test .loc with uint64 numbers #23879

merged 1 commit into from
Nov 25, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 23, 2018

Closes #19399.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves labels Nov 23, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 23, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 23, 2018 •
edited
Loading

Codecov Report

Merging #23879 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23879   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51498    51498           
=======================================
  Hits        47530    47530           
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.69% <ø> (ø) ⬆️
#single 42.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ce05d...fe4dd2c. Read the comment docs.

WillAyd
WillAyd approved these changes Nov 24, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 3117f78 into pandas-dev:master Nov 25, 2018
@jreback
Copy link
Contributor

jreback commented Nov 25, 2018

thanks @gfyoung

@gfyoung gfyoung deleted the series-uint64-loc-test branch November 25, 2018 02:23
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
TST: Test .loc with uint64 numbers (pandas-dev#23879)
d328b2a 
Closes pandas-devgh-19399.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
TST: Test .loc with uint64 numbers (pandas-dev#23879)
0282d9b 
Closes pandas-devgh-19399.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gfyoung @pep8speaks @jreback @WillAyd