Skip to content

REF/TST: Add more pytest idiom to parsers tests #23810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 20, 2018

Adds more idiom to the following:

  • parser/header --> parser/test_header
  • parser/dtypes --> parser/test_dtypes
  • parser/index_col --> parser/test_index_col
  • parser/mangle_dupes --> parser/test_mangle_dupes

Builds off of #23712.

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite IO CSV read_csv, to_csv labels Nov 20, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 20, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

Adds more idiom to the following:

* parser/header --> parser/test_header
* parser/dtypes --> parser/test_dtypes
* parser/index_col --> parser/test_index_col
* parser/mangle_dupes --> parser/test_mangle_dupes

Builds off of pandas-devgh-23712.
@gfyoung gfyoung force-pushed the pytest-idiom-parsers branch from cb629d0 to 73bdfad Compare November 20, 2018 10:19
@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #23810 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23810   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         161      161           
  Lines       51457    51457           
=======================================
  Hits        47489    47489           
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5eeec...73bdfad. Read the comment docs.

@jreback jreback merged commit a289aee into pandas-dev:master Nov 20, 2018
@jreback
Copy link
Contributor

jreback commented Nov 20, 2018

thanks!

thoo added a commit to thoo/pandas that referenced this pull request Nov 20, 2018
…fixed

* upstream/master:
  DOC: Removing rpy2 dependencies, and converting examples using it to regular code blocks (pandas-dev#23737)
  BUG: Fix dtype=str converts NaN to 'n' (pandas-dev#22564)
  DOC: update pandas.core.resample.Resampler.nearest docstring (pandas-dev#20381)
  REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23810)
  Added support for Fraction and Number (PEP 3141) to pandas.api.types.is_scalar (pandas-dev#22952)
  DOC: Updating to_timedelta docstring (pandas-dev#23259)
@gfyoung gfyoung deleted the pytest-idiom-parsers branch November 20, 2018 17:20
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Adds more idiom to the following:

* parser/header --> parser/test_header
* parser/dtypes --> parser/test_dtypes
* parser/index_col --> parser/test_index_col
* parser/mangle_dupes --> parser/test_mangle_dupes

Builds off of pandas-devgh-23712.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Adds more idiom to the following:

* parser/header --> parser/test_header
* parser/dtypes --> parser/test_dtypes
* parser/index_col --> parser/test_index_col
* parser/mangle_dupes --> parser/test_mangle_dupes

Builds off of pandas-devgh-23712.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants