-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Make assert_extension_array_equal behavior consistent #23808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Make assert_extension_array_equal behavior consistent #23808
Conversation
Hello @jschendel! Thanks for submitting the PR.
|
Seems like a precision issue on the py2 test: https://travis-ci.org/pandas-dev/pandas/jobs/457327081#L2551 |
Codecov Report
@@ Coverage Diff @@
## master #23808 +/- ##
==========================================
+ Coverage 92.28% 92.28% +<.01%
==========================================
Files 161 161
Lines 51457 51465 +8
==========================================
+ Hits 47489 47497 +8
Misses 3968 3968
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging later today.
@jschendel thanks! |
Should #23605 also be closed? |
Yes, will close that issue manually. The latest pandas-wheels build was successful, which looks to include this PR based on the time at which it was started: https://travis-ci.org/MacPython/pandas-wheels/builds/457775113 |
yep looks like the 32 bit are finally fixed thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff
Doesn't seem like a whatsnew entry is needed for this, but can add one if need be.
This should also address #23605; I don't want to autoclose it, as I'd rather wait to confirm that the nightly build passes after this is merged.