Skip to content

TST: Make assert_extension_array_equal behavior consistent #23808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

jschendel
Copy link
Member

Doesn't seem like a whatsnew entry is needed for this, but can add one if need be.

This should also address #23605; I don't want to autoclose it, as I'd rather wait to confirm that the nightly build passes after this is merged.

@jschendel jschendel added Testing pandas testing functions or related to the test suite ExtensionArray Extending pandas with custom dtypes or arrays. labels Nov 20, 2018
@jschendel jschendel added this to the 0.24.0 milestone Nov 20, 2018
@pep8speaks
Copy link

Hello @jschendel! Thanks for submitting the PR.

@TomAugspurger
Copy link
Contributor

Seems like a precision issue on the py2 test: https://travis-ci.org/pandas-dev/pandas/jobs/457327081#L2551

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #23808 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23808      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         161      161              
  Lines       51457    51465       +8     
==========================================
+ Hits        47489    47497       +8     
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.68% <100%> (ø) ⬆️
#single 42.31% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 86.09% <100%> (+0.05%) ⬆️
pandas/core/tools/timedeltas.py 98.03% <0%> (ø) ⬆️
pandas/core/resample.py 96.99% <0%> (ø) ⬆️
pandas/core/dtypes/cast.py 88.99% <0%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5eeec...ee46ee0. Read the comment docs.

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging later today.

@jorisvandenbossche jorisvandenbossche merged commit 3625e1e into pandas-dev:master Nov 21, 2018
@jorisvandenbossche
Copy link
Member

@jschendel thanks!

@jorisvandenbossche
Copy link
Member

Should #23605 also be closed?

@jschendel jschendel deleted the ea-test-precision branch November 21, 2018 17:35
@jschendel
Copy link
Member Author

Should #23605 also be closed?

Yes, will close that issue manually. The latest pandas-wheels build was successful, which looks to include this PR based on the time at which it was started: https://travis-ci.org/MacPython/pandas-wheels/builds/457775113

@jreback
Copy link
Contributor

jreback commented Nov 21, 2018

yep looks like the 32 bit are finally fixed thanks!

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@lithomas1 lithomas1 mentioned this pull request Jun 14, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: assert_extension_array_equal is inconsistent in how precision is handled
5 participants