-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API: Make Series.searchsorted return a scalar, when supplied a scalar #23801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 4 commits into
pandas-dev:master
from
topper-123:Series.searchsorted_api
Dec 21, 2018
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
|
||
import pandas as pd | ||
from pandas import Index, IntervalIndex, MultiIndex | ||
from pandas.api.types import is_scalar | ||
|
||
|
||
def test_is_monotonic_increasing(): | ||
|
@@ -182,22 +183,28 @@ def test_searchsorted_monotonic(indices): | |
# test searchsorted only for increasing | ||
if indices.is_monotonic_increasing: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pls don't import is_scalar from testing, import it from the canonical location pandas.api.types.is_scalar. |
||
ssm_left = indices._searchsorted_monotonic(value, side='left') | ||
assert is_scalar(ssm_left) | ||
assert expected_left == ssm_left | ||
|
||
ssm_right = indices._searchsorted_monotonic(value, side='right') | ||
assert is_scalar(ssm_right) | ||
assert expected_right == ssm_right | ||
|
||
ss_left = indices.searchsorted(value, side='left') | ||
assert is_scalar(ss_left) | ||
assert expected_left == ss_left | ||
|
||
ss_right = indices.searchsorted(value, side='right') | ||
assert is_scalar(ss_right) | ||
assert expected_right == ss_right | ||
|
||
elif indices.is_monotonic_decreasing: | ||
ssm_left = indices._searchsorted_monotonic(value, side='left') | ||
assert is_scalar(ssm_left) | ||
assert expected_left == ssm_left | ||
|
||
ssm_right = indices._searchsorted_monotonic(value, side='right') | ||
assert is_scalar(ssm_right) | ||
assert expected_right == ssm_right | ||
|
||
else: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@datapythonista is this the correct format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but can you use
int or array of int
(I'd like to parse at some point the types from these, so I prefer the type nameint
overints
)