-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Extend datetime64 arith tests to array classes, fix several broken cases #23771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fa72d87
box over array classes
jbrockmendel 3327ba0
remove singleton fixture
jbrockmendel ee8cd5e
parametrize over array class, fix timestamp - timedeltarray
jbrockmendel cc40b37
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel 59f906f
Wrap timedelta64 results in TimedeltaArray
jbrockmendel b098e56
parametrize over box, xfail
jbrockmendel 09f4887
parametrize+test dateoffset tests
jbrockmendel 6bf389e
use box_with_array just a bit more
jbrockmendel 3b56991
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel 18a1301
use box_with_array in more period tests
jbrockmendel 5c30f32
use int_holder instead of box where appropriate
jbrockmendel c999a59
Fix DateOffset-with-DataFrame ops
jbrockmendel 1fbb5d5
flake8 fixup
jbrockmendel fcc67d9
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel 0c4ad24
Revert code changes, use xfails instead
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -300,6 +300,11 @@ def _evaluate_with_timedelta_like(self, other, op): | |
|
||
return NotImplemented | ||
|
||
def __neg__(self): | ||
if self.freq is not None: | ||
return type(self)(-self._data, freq=-self.freq) | ||
return type(self)(-self._data) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will be made unnecessary by #23642. |
||
# ---------------------------------------------------------------- | ||
# Conversion Methods - Vectorized analogues of Timedelta methods | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth comments here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. It would just say
# wrap result in TimedeltaArray
which is pretty redundant given the one-liner here