Skip to content

DOC: Update escapechar param description for read_csv #23770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mhlevgen
Copy link

@mhlevgen mhlevgen commented Nov 18, 2018

@pep8speaks
Copy link

Hello @mhlevgen! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #23770 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23770   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51433    51433           
=======================================
  Hits        47446    47446           
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 42.28% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/parsers.py 95.55% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d1c50...41a7df6. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Nov 18, 2018

what issue is this closing?

@jreback jreback added Docs IO CSV read_csv, to_csv labels Nov 18, 2018
@mhlevgen
Copy link
Author

mhlevgen commented Nov 19, 2018 via email

@datapythonista datapythonista changed the title DOC: remove quoting comment from escapechar description (pandas-dev#2… DOC: Update escapechar param description for read_csv Nov 19, 2018
@datapythonista
Copy link
Member

@mhlevgen thanks for the contribution. Besides the incorrection regarding the quoting, I don't think the description of the escapechar parameter is very clear. Do you think you can improve it in this same PR?

@datapythonista
Copy link
Member

@mhlevgen do you have time to fix the conflicts?

@datapythonista
Copy link
Member

Closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Weird documentation (or behavior) of pd.read_csv escapechar= arg
4 participants