Skip to content

BUG Rename during dependency generation from conda #23740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

FHaase
Copy link
Contributor

@FHaase FHaase commented Nov 16, 2018

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Package pytables wasn't renamed as it was compared to full package specification.

Signed-off-by: Fabian Haase <[email protected]>
@pep8speaks
Copy link

Hello @FHaase! Thanks for submitting the PR.

@jreback jreback added the Clean label Nov 16, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 16, 2018
@jreback
Copy link
Contributor

jreback commented Nov 16, 2018

lgtm. @TomAugspurger

@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #23740 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23740   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files         161      161           
  Lines       51383    51383           
=======================================
  Hits        47404    47404           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98032d...c240a8c. Read the comment docs.

@TomAugspurger
Copy link
Contributor

Thanks. Opened #23741 for the azure failure.

@TomAugspurger TomAugspurger merged commit b92f85c into pandas-dev:master Nov 16, 2018
@FHaase FHaase deleted the fix-generate-pip-deps branch November 16, 2018 16:55
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants