TST/CLN: Fix/clean pytables test #23732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @h-vetinari! Thanks for submitting the PR.
|
|
Failure is due to #23726 |
|
not sure this actually solves a problem. |
|
As I laid out in the OP, this solves a flaky test that doesn't fail in the CI (clean image every time), but it failed about 10x for me locally, and it was obvious from the error that the same input hat been written to a store key twice. Hence adding the It's a small change, but why not make the test suite more stable? |
gfyoung
added
Testing
|
ok I don't think these actually fix anything, but can't hur that original function should be a contextmanager anyhow (welcome PR on that). |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #23731, I sometimes got a failing test for pytables -- based on the rest of the test, it seemed pretty clear that the
_maybe_remove(store, 'xx')was not consistently used throughout the test, and so I thought I'd add it. I'm guessing the CI never hits this failure because it seems it would need more replications for that.