CI for boto: fix errors; add coverage; add skip for uncatchable ResourceWarning

ci/deps/travis-36.yaml

@@ -4,6 +4,7 @@ channels:
   - conda-forge
 dependencies:
   - beautifulsoup4
+  - botocore>=1.11
   - cython>=0.28.2
   - dask
   - fastparquet

ci/deps/travis-37.yaml

@@ -5,6 +5,7 @@ channels:
   - c3i_test
 dependencies:
   - python=3.7
+  - botocore>=1.11
   - cython>=0.28.2
   - numpy
   - python-dateutil
@@ -14,3 +15,6 @@ dependencies:
   - pytest
   - pytest-xdist
   - hypothesis>=3.58.0
+  - s3fs
+  - pip:
+    - moto

pandas/tests/io/conftest.py

@@ -1,4 +1,7 @@
+import os
+
 import pytest
+
 from pandas.io.parsers import read_csv
 
 
@@ -37,6 +40,12 @@ def s3_resource(tips_file, jsonl_file):
     """
     pytest.importorskip('s3fs')
     boto3 = pytest.importorskip('boto3')
+
+    # temporary workaround as moto fails for botocore >= 1.11 otherwise
+    # see https://github.com/spulec/moto/issues/1924 & 1952
+    os.environ.setdefault("AWS_ACCESS_KEY_ID", "foobar_key")
+    os.environ.setdefault("AWS_SECRET_ACCESS_KEY", "foobar_secret")
+
     # GH-24092. See if boto.plugin skips the test or fails.
     try:
         pytest.importorskip("boto.plugin")
@@ -59,7 +68,6 @@ def add_tips_files(bucket_name):
                     Body=f)
 
     try:
-
         s3 = moto.mock_s3()
         s3.start()
 
@@ -73,7 +81,5 @@ def add_tips_files(bucket_name):
         conn.create_bucket(Bucket='cant_get_it', ACL='private')
         add_tips_files('cant_get_it')
         yield conn
-    except:  # noqa: flake8
-        pytest.skip("failure to use s3 resource")
     finally:
         s3.stop()