-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Fixing possible bugs in the CI #23727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
57aca9a
08ccb80
cfc89a5
c8d20b1
9718fd5
b3f5744
22b8fc2
5afef71
6f17fe5
23d0c17
d08c0a8
e1a6f89
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ dependencies: | |
- pymysql | ||
- pytables | ||
- python-dateutil | ||
- python=3.6* | ||
- python=3.7* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the name of the file we say it's 37, I guess the version here is wrong. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like this is breaking the installation of this build, as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like conda-forge/moto-feedstock#15 is failing on a dependency. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @datapythonista @TomAugspurger It's possible to install it through pip - I did that in #23731, but then the problem is that |
||
- pytz | ||
- s3fs | ||
- scipy | ||
|
@@ -30,6 +30,6 @@ dependencies: | |
# universal | ||
- pytest | ||
- pytest-xdist | ||
- moto | ||
- pip: | ||
- hypothesis>=3.58.0 | ||
- moto # latest moto in conda-forge fails with 3.7, move to conda dependencies when this is fixed |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ source activate pandas | |
|
||
if [ -n "$LOCALE_OVERRIDE" ]; then | ||
export LC_ALL="$LOCALE_OVERRIDE"; | ||
export LANG="$LOCALE_OVERRIDE"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have this in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you could add this would prob be ok |
||
echo "Setting LC_ALL to $LOCALE_OVERRIDE" | ||
|
||
pycmd='import pandas; print("pandas detected console encoding: %s" % pandas.get_option("display.encoding"))' | ||
|
@@ -32,8 +33,12 @@ elif [ "$COVERAGE" ]; then | |
|
||
elif [ "$SLOW" ]; then | ||
TEST_ARGS="--only-slow --skip-network" | ||
echo pytest -m "not single and slow" -v --durations=10 --junitxml=test-data-multiple.xml --strict $TEST_ARGS pandas | ||
pytest -m "not single and slow" -v --durations=10 --junitxml=test-data-multiple.xml --strict $TEST_ARGS pandas | ||
# The `-m " and slow"` is redundant here, as `--only-slow` is already used (via $TEST_ARGS). But is needed, because with | ||
# `--only-slow` fast tests are skipped, but each of them is printed in the log (which can be avoided with `-q`), | ||
# and also added to `test-data-multiple.xml`, and then printed in the log in the call to `ci/print_skipped.py`. | ||
# Printing them to the log makes the log exceed the maximum size allowed by Travis and makes the build fail. | ||
echo pytest -n 2 -m "not single and slow" --durations=10 --junitxml=test-data-multiple.xml --strict $TEST_ARGS pandas | ||
pytest -n 2 -m "not single and slow" --durations=10 --junitxml=test-data-multiple.xml --strict $TEST_ARGS pandas | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not easy to see in the diff, but note that I added the |
||
|
||
else | ||
echo pytest -n 2 -m "not single" --durations=10 --junitxml=test-data-multiple.xml --strict $TEST_ARGS pandas | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,31 @@ | ||
# pylint: disable=E1101 | ||
import os | ||
import warnings | ||
from datetime import datetime, date, time, timedelta | ||
from collections import OrderedDict | ||
import contextlib | ||
from datetime import date, datetime, time, timedelta | ||
from distutils.version import LooseVersion | ||
from functools import partial | ||
import os | ||
import warnings | ||
from warnings import catch_warnings | ||
from collections import OrderedDict | ||
|
||
import numpy as np | ||
import pytest | ||
from numpy import nan | ||
import pytest | ||
|
||
import pandas as pd | ||
import pandas.util.testing as tm | ||
from pandas.compat import PY36, BytesIO, iteritems, map, range, u | ||
import pandas.util._test_decorators as td | ||
|
||
import pandas as pd | ||
from pandas import DataFrame, Index, MultiIndex, Series | ||
from pandas.compat import u, range, map, BytesIO, iteritems, PY36 | ||
from pandas.core.config import set_option, get_option | ||
from pandas.core.config import get_option, set_option | ||
import pandas.util.testing as tm | ||
from pandas.util.testing import ensure_clean, makeCustomDataframe as mkdf | ||
|
||
from pandas.io.common import URLError | ||
from pandas.io.excel import ( | ||
ExcelFile, ExcelWriter, read_excel, _XlwtWriter, _OpenpyxlWriter, | ||
register_writer, _XlsxWriter | ||
) | ||
ExcelFile, ExcelWriter, _OpenpyxlWriter, _XlsxWriter, _XlwtWriter, | ||
read_excel, register_writer) | ||
from pandas.io.formats.excel import ExcelFormatter | ||
from pandas.io.parsers import read_csv | ||
from pandas.util.testing import ensure_clean, makeCustomDataframe as mkdf | ||
|
||
|
||
_seriesd = tm.getSeriesData() | ||
_tsd = tm.getTimeSeriesData() | ||
|
@@ -36,6 +36,20 @@ | |
_mixed_frame['foo'] = 'bar' | ||
|
||
|
||
@contextlib.contextmanager | ||
def ignore_xlrd_time_clock_warning(): | ||
""" | ||
Context manager to ignore warnings raised by the xlrd library, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hmm, is this still present in 1.0.0 which is now our min version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it happens in |
||
regarding the deprecation of `time.clock` in Python 3.7. | ||
""" | ||
with warnings.catch_warnings(): | ||
warnings.filterwarnings( | ||
action='ignore', | ||
message='time.clock has been deprecated', | ||
category=DeprecationWarning) | ||
yield | ||
|
||
|
||
@td.skip_if_no('xlrd', '1.0.0') | ||
class SharedItems(object): | ||
|
||
|
@@ -114,20 +128,23 @@ def test_usecols_int(self, ext): | |
# usecols as int | ||
with tm.assert_produces_warning(FutureWarning, | ||
check_stacklevel=False): | ||
df1 = self.get_exceldf("test1", ext, "Sheet1", | ||
index_col=0, usecols=3) | ||
with ignore_xlrd_time_clock_warning(): | ||
df1 = self.get_exceldf("test1", ext, "Sheet1", | ||
index_col=0, usecols=3) | ||
|
||
# usecols as int | ||
with tm.assert_produces_warning(FutureWarning, | ||
check_stacklevel=False): | ||
df2 = self.get_exceldf("test1", ext, "Sheet2", skiprows=[1], | ||
index_col=0, usecols=3) | ||
with ignore_xlrd_time_clock_warning(): | ||
df2 = self.get_exceldf("test1", ext, "Sheet2", skiprows=[1], | ||
index_col=0, usecols=3) | ||
|
||
# parse_cols instead of usecols, usecols as int | ||
with tm.assert_produces_warning(FutureWarning, | ||
check_stacklevel=False): | ||
df3 = self.get_exceldf("test1", ext, "Sheet2", skiprows=[1], | ||
index_col=0, parse_cols=3) | ||
with ignore_xlrd_time_clock_warning(): | ||
df3 = self.get_exceldf("test1", ext, "Sheet2", skiprows=[1], | ||
index_col=0, parse_cols=3) | ||
|
||
# TODO add index to xls file) | ||
tm.assert_frame_equal(df1, df_ref, check_names=False) | ||
|
@@ -145,8 +162,9 @@ def test_usecols_list(self, ext): | |
index_col=0, usecols=[0, 2, 3]) | ||
|
||
with tm.assert_produces_warning(FutureWarning): | ||
df3 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1], | ||
index_col=0, parse_cols=[0, 2, 3]) | ||
with ignore_xlrd_time_clock_warning(): | ||
df3 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1], | ||
index_col=0, parse_cols=[0, 2, 3]) | ||
|
||
# TODO add index to xls file) | ||
tm.assert_frame_equal(df1, dfref, check_names=False) | ||
|
@@ -165,8 +183,9 @@ def test_usecols_str(self, ext): | |
index_col=0, usecols='A:D') | ||
|
||
with tm.assert_produces_warning(FutureWarning): | ||
df4 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1], | ||
index_col=0, parse_cols='A:D') | ||
with ignore_xlrd_time_clock_warning(): | ||
df4 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1], | ||
index_col=0, parse_cols='A:D') | ||
|
||
# TODO add index to xls, read xls ignores index name ? | ||
tm.assert_frame_equal(df2, df1, check_names=False) | ||
|
@@ -618,8 +637,9 @@ def test_sheet_name_and_sheetname(self, ext): | |
df1 = self.get_exceldf(filename, ext, | ||
sheet_name=sheet_name, index_col=0) # doc | ||
with tm.assert_produces_warning(FutureWarning, check_stacklevel=False): | ||
df2 = self.get_exceldf(filename, ext, index_col=0, | ||
sheetname=sheet_name) # backward compat | ||
with ignore_xlrd_time_clock_warning(): | ||
df2 = self.get_exceldf(filename, ext, index_col=0, | ||
sheetname=sheet_name) # backward compat | ||
|
||
excel = self.get_excelfile(filename, ext) | ||
df1_parse = excel.parse(sheet_name=sheet_name, index_col=0) # doc | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
CONDA_PY
we have37
, as well as in the yaml file, so I assume the name is wrong.