TST: clean up to change setup.cfg to xfail_strict = True (GH23057)

[dcreekp]

• closes Make default xfail strict #23057
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[pep8speaks]

Hello @dcreekp! Thanks for updating the PR.

• There are no PEP8 issues in the file pandas/tests/indexing/test_coercion.py !

• There are no PEP8 issues in the file pandas/tests/io/test_parquet.py !

• There are no PEP8 issues in the file pandas/tests/plotting/test_datetimelike.py !

• There are no PEP8 issues in the file pandas/tests/plotting/test_frame.py !

• There are no PEP8 issues in the file pandas/tests/plotting/test_misc.py !

• There are no PEP8 issues in the file pandas/tests/plotting/test_series.py !

• There are no PEP8 issues in the file pandas/tests/scalar/period/test_period.py !

• There are no PEP8 issues in the file pandas/util/_test_decorators.py !

Comment last updated on November 15, 2018 at 20:09 Hours UTC

[codecov]

Codecov Report

Merging #23721 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23721   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         161      161           
  Lines       51562    51562           
=======================================
  Hits        47599    47599           
  Misses       3963     3963

Flag	Coverage Δ
#multiple	90.71% <ø> (ø)	⬆️
#single	42.44% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/util/_test_decorators.py	93.24% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7bdf7c...19bfbf3. Read the comment docs.

[TomAugspurger]

Looks like there are some xfailing tests that are passing: https://travis-ci.org/pandas-dev/pandas/jobs/455669456#L2806

There may be others in https://travis-ci.org/pandas-dev/pandas/builds/455669455?utm_source=github_status&utm_medium=notification, I only looked at the first build.

The ones that are flaky should be xfail(strict=False).

[dcreekp]

@TomAugspurger @jbrockmendel
Oh I get it.
At least for https://travis-ci.org/pandas-dev/pandas/jobs/455669458 and https://travis-ci.org/pandas-dev/pandas/jobs/455669460 they are xpassing when running py3.7 on travis, while running py3.6 locally they didn't xpass

[dcreekp]

this one https://travis-ci.org/pandas-dev/pandas/jobs/455669458
will probably still fail because it is the same as this #23726

[jreback]

can you rebase

[jreback]

you are picking up other changes. merge master and push again.

[jreback]

better for this one

[TomAugspurger]

Diff looks good here. CI is still failing from tests xpassing. You may need to add conditions or strict=False to those xfails.

https://travis-ci.org/pandas-dev/pandas/jobs/461026497#L2987

[jreback]

can you merge master and let's see the ci run again.

[jreback]

lgtm. @TomAugspurger

[TomAugspurger]

Thanks @dcreekp! This will be very useful.

[dcreekp]

Awesome.
Just to let you know, as python2.7 support is going to be dropped. There are two or three tests that are marked xfail only because of the test failing on 2.7.
@TomAugspurger @jreback