-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: 'Unnamed' != unnamed column in CSV #23687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: 'Unnamed' != unnamed column in CSV #23687
Conversation
Hello @gfyoung! Thanks for submitting the PR.
|
ec41e07
to
7bcca7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #23687 +/- ##
==========================================
- Coverage 92.25% 92.25% -0.01%
==========================================
Files 161 161
Lines 51383 51381 -2
==========================================
- Hits 47404 47402 -2
Misses 3979 3979
Continue to review full report at Codecov.
|
7bcca7b
to
8e92e4c
Compare
@jreback : Address the comment, and all is still green. PTAL. |
conflict in the whatsnew, can you merge master |
8e92e4c
to
52cc5c9
Compare
@jreback : Rebased my changes, and all is green. PTAL. |
False criterion was causing errors when specified headers appeared to capture a seemingly unnamed row, just because they had the string "Unnamed" in it.
52cc5c9
to
ff68dbd
Compare
@jreback : Addressed all comments, all is still green. PTAL. |
thanks! |
False criterion was causing errors when specified headers appeared to capture a seemingly unnamed row, just because they had the string "Unnamed" in it.
False criterion was causing errors when specified headers appeared to capture a seemingly unnamed row, just because they had the string "Unnamed" in it.
False criterion was causing errors when specified headers appeared to capture a seemingly unnamed row, just because they had the string "Unnamed" in it.
I'm getting bunch of these "unnamed ..." where my column is empty. Is this related to the same bug?
|
@SamLevinSE : I don't believe so. However, if you are welcome to open a new issue to provide more details, as it could still be a problem with |
@gfyoung What if I give you some more Information? could you please check these two screenshots and let me know if I need to create a new bug/issue or if I'm doing something wrong? |
This looks expected as far as I can see. |
False criterion was causing errors when specified headers appeared to capture
a seemingly unnamed row, just because they had the string "Unnamed" in it.
Setup:
Previously, this would error:
Now, it nicely returns a
DataFrame
:Leverages the patch used in #23484 of
self.unnamed_cols
.