Skip to content

TST: Test cleanup, parametrization for datetime64 arithmetic tests #23681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 16, 2018
Merged

TST: Test cleanup, parametrization for datetime64 arithmetic tests #23681

merged 13 commits into from
Nov 16, 2018

Conversation

jbrockmendel
Copy link
Member

Avoids overlap with #23642.

@pep8speaks
Copy link

pep8speaks commented Nov 14, 2018 •
edited
Loading

Hello @jbrockmendel! Thanks for updating the PR.

Comment last updated on November 14, 2018 at 01:59 Hours UTC

@codecov
Copy link

codecov bot commented Nov 14, 2018 •
edited
Loading

Codecov Report

Merging #23681 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23681      +/-   ##
==========================================
+ Coverage   92.25%   92.25%   +<.01%     
==========================================
  Files         161      161              
  Lines       51383    51385       +2     
==========================================
+ Hits        47404    47406       +2     
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.64% <100%> (ø) ⬆️
#single 42.31% <80%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimes.py 98.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23f901...ddb1662. Read the comment docs.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Datetime Datetime data dtype Clean labels Nov 14, 2018
jreback
jreback requested changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of nitpicks, most can be done later.

pandas/tests/scalar/period/test_period.py
msg = ('Frequency must be positive, because it' ' represents span: 0M')
with pytest.raises(ValueError, match=msg):
Period('2011-01', freq='0M')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can parametrize next pass (and maybe split to 2 tests, working and error condtiions)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah, I've got another branch focusing more closely on the scalar tests, will work this in there.

pandas/tests/scalar/period/test_period.py
assert i1.freq == offsets.Minute()
assert i1.freqstr == 'T'

def test_period_deprecated_freq(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you parametrize next pass

@jreback jreback added this to the 0.24.0 milestone Nov 14, 2018
@jbrockmendel jbrockmendel mentioned this pull request Nov 14, 2018
Closed
@jbrockmendel
Copy link
Member Author

Possible segfault in test_rank? I think this was changed s few days ago

@jbrockmendel
Copy link
Member Author

gentle ping

@jbrockmendel jbrockmendel mentioned this pull request Nov 16, 2018
Closed
TomAugspurger
TomAugspurger approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Will merge later today to give @jreback a chance to look if he wants.

@jreback jreback merged commit b53a1a8 into pandas-dev:master Nov 16, 2018
@jreback
Copy link
Contributor

jreback commented Nov 16, 2018

thanks @jbrockmendel

seems 2.7 build is failing on last merge @TomAugspurger ?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Nov 16, 2018 via email

@jbrockmendel jbrockmendel deleted the atests branch November 16, 2018 17:27
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@jbrockmendel @tm9k1
TST: Test cleanup, parametrization for datetime64 arithmetic tests (p…
80d6dd4 
…andas-dev#23681)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
TST: Test cleanup, parametrization for datetime64 arithmetic tests (p…
ef3761c 
…andas-dev#23681)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
TST: Test cleanup, parametrization for datetime64 arithmetic tests (p…
73d8284 
…andas-dev#23681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Clean Datetime Datetime data dtype Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jbrockmendel @pep8speaks @jreback @TomAugspurger @gfyoung