CI/DOC: Fixing bug in validate_docstrings.py #23543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rong place, raised a KeyError when a private class was found in a docstrings (and adding test for that case
|
Hello @datapythonista! Thanks for submitting the PR.
|
datapythonista
changed the title
Codecov Report
@@ Coverage Diff @@
## master #23543 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 161 161
Lines 51207 51207
=======================================
Hits 47239 47239
Misses 3968 3968
Continue to review full report at Codecov.
|
TomAugspurger
approved these changes
Nov 7, 2018
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
…rong place, raised a KeyError when a private class was found in a docstrings (and adding test for that case (pandas-dev#23543)
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
…rong place, raised a KeyError when a private class was found in a docstrings (and adding test for that case (pandas-dev#23543)
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
…rong place, raised a KeyError when a private class was found in a docstrings (and adding test for that case (pandas-dev#23543)
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
…rong place, raised a KeyError when a private class was found in a docstrings (and adding test for that case (pandas-dev#23543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #23514. One of the validation error wasn't tested, and with the refactoring a typo was introduced, where a bracket closed in the wrong place, raised a KeyError when a private class was found in a docstrings (and adding test for that case
git diff upstream/master -u -- "*.py" | flake8 --diff