Skip to content

DOC/TST: Fix warning in concat docstring #23529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

TomAugspurger
Copy link
Contributor

xref #23149

@pep8speaks
Copy link

Hello @TomAugspurger! Thanks for submitting the PR.

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Nov 6, 2018
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #23529 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23529      +/-   ##
==========================================
+ Coverage   92.25%   92.25%   +<.01%     
==========================================
  Files         161      161              
  Lines       51181    51186       +5     
==========================================
+ Hits        47217    47222       +5     
  Misses       3964     3964
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 42.27% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/concat.py 97.6% <ø> (ø) ⬆️
pandas/core/groupby/groupby.py 96.51% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd98841...dc9fadf. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

checked the log, and seems like it fixes the specifying 'categories' or 'ordered' in .astype() is deprecated; pass a CategoricalDtype instead warning

@TomAugspurger TomAugspurger merged commit e863972 into pandas-dev:master Nov 6, 2018
@TomAugspurger TomAugspurger deleted the concat-doctest branch November 6, 2018 19:21
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants