Skip to content

Extraneous parts broken off from other DTA/TDA PRs #23518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

Extraneous parts broken off from other DTA/TDA PRs #23518

merged 1 commit into from
Nov 6, 2018

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@gfyoung gfyoung added Datetime Datetime data dtype Clean labels Nov 5, 2018
@gfyoung gfyoung requested a review from jreback November 5, 2018 20:20
@codecov
Copy link

codecov bot commented Nov 5, 2018 •
edited
Loading

Codecov Report

Merging #23518 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23518      +/-   ##
==========================================
+ Coverage   92.23%   92.23%   +<.01%     
==========================================
  Files         161      161              
  Lines       51197    51198       +1     
==========================================
+ Hits        47220    47221       +1     
  Misses       3977     3977
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 42.27% <63.63%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 96.09% <ø> (-0.02%) ⬇️
pandas/core/indexes/timedeltas.py 90.71% <ø> (-0.03%) ⬇️
pandas/core/arrays/period.py 98.08% <100%> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.41% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 98.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0877ec...5be1a0d. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Nov 6, 2018
@jreback
Copy link
Contributor

jreback commented Nov 6, 2018

lgtm.

@jbrockmendel
Copy link
Member Author

The failures here are all in openpyxl. Is that causing problems in master right now?

@jreback
Copy link
Contributor

jreback commented Nov 6, 2018

yeah its not hitting master which is odd.

@jreback jreback merged commit 0f99f61 into pandas-dev:master Nov 6, 2018
@jbrockmendel jbrockmendel deleted the pre-misc branch November 6, 2018 03:39
jorisvandenbossche
jorisvandenbossche reviewed Nov 8, 2018
View reviewed changes
pandas/core/indexes/datetimes.py
_freq = None
_comparables = ['name', 'freqstr', 'tz']
_attributes = ['name', 'freq', 'tz']

# dummy attribute so that datetime.__eq__(DatetimeArray) defers
# by returning NotImplemented
timetuple = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not yet tested I suppose then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is accurate.

JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
@jbrockmendel @JustinZhengBC
Extraneous parts broken off from other PRS (pandas-dev#23518)
b34cfff
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@jbrockmendel @tm9k1
Extraneous parts broken off from other PRS (pandas-dev#23518)
fee0402
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
Extraneous parts broken off from other PRS (pandas-dev#23518)
66b9204
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
Extraneous parts broken off from other PRS (pandas-dev#23518)
c552b6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jbrockmendel @pep8speaks @jreback @jorisvandenbossche @gfyoung