Skip to content

BUG - pd.concat with all Series on axis=1 ignores the names argument (Issue: 23490) #23499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2018

Conversation

ms7463
Copy link
Contributor

@ms7463 ms7463 commented Nov 4, 2018

Fix issue described in #23490, and add tests to catch this case.

@pep8speaks
Copy link

Hello @ArtinSarraf! Thanks for submitting the PR.

@gfyoung gfyoung added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 4, 2018
@ms7463
Copy link
Contributor Author

ms7463 commented Nov 6, 2018

@gfyoung - Is there a way to rerun the Travis CI build? I get the following error in the logs, and it doesn't seem to be explicitly related to any of my changes.

"No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated"

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #23499 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23499      +/-   ##
==========================================
+ Coverage   92.23%   92.25%   +0.02%     
==========================================
  Files         161      161              
  Lines       51197    51169      -28     
==========================================
- Hits        47220    47207      -13     
+ Misses       3977     3962      -15
Flag Coverage Δ
#multiple 90.64% <100%> (+0.02%) ⬆️
#single 42.28% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/concat.py 97.6% <100%> (ø) ⬆️
pandas/core/tools/timedeltas.py 98.18% <0%> (-0.24%) ⬇️
pandas/core/indexes/timedeltas.py 90.71% <0%> (-0.03%) ⬇️
pandas/core/arrays/datetimelike.py 96.09% <0%> (-0.02%) ⬇️
pandas/core/strings.py 98.58% <0%> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.41% <0%> (ø) ⬆️
pandas/core/frame.py 97.03% <0%> (ø) ⬆️
pandas/util/_test_decorators.py 93.24% <0%> (ø) ⬆️
pandas/core/groupby/generic.py 87.04% <0%> (ø) ⬆️
pandas/core/arrays/period.py 98.08% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ab22f...3e624e8. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Nov 6, 2018
@jreback
Copy link
Contributor

jreback commented Nov 6, 2018

great. ping on green.

@gfyoung gfyoung merged commit c992fd7 into pandas-dev:master Nov 6, 2018
@gfyoung
Copy link
Member

gfyoung commented Nov 6, 2018

Thanks @ArtinSarraf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pd.concat with all Series on axis=1 ignores the names argument.
5 participants